Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3652)

Unified Diff: chrome/browser/ui/views/payments/credit_card_editor_view_controller_browsertest.cc

Issue 2807363003: [Payments] After adding/editing a credit card, instrument is selected. (Closed)
Patch Set: include fix Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/payments/credit_card_editor_view_controller_browsertest.cc
diff --git a/chrome/browser/ui/views/payments/credit_card_editor_view_controller_browsertest.cc b/chrome/browser/ui/views/payments/credit_card_editor_view_controller_browsertest.cc
index 08bce0bfdf4c4e9a4c336cbc29368a8b255d886e..b470617d5dae96e30f57e3b6b008ce4ccb1ffc07 100644
--- a/chrome/browser/ui/views/payments/credit_card_editor_view_controller_browsertest.cc
+++ b/chrome/browser/ui/views/payments/credit_card_editor_view_controller_browsertest.cc
@@ -49,6 +49,11 @@ IN_PROC_BROWSER_TEST_F(PaymentRequestCreditCardEditorTest, EnteringValidData) {
InvokePaymentRequestUI();
+ // No instruments are available.
+ PaymentRequest* request = GetPaymentRequests(GetActiveWebContents()).front();
+ EXPECT_EQ(0U, request->state()->available_instruments().size());
+ EXPECT_EQ(nullptr, request->state()->selected_instrument());
+
OpenPaymentMethodScreen();
OpenCreditCardEditorScreen();
@@ -82,6 +87,11 @@ IN_PROC_BROWSER_TEST_F(PaymentRequestCreditCardEditorTest, EnteringValidData) {
EXPECT_EQ(base::ASCIIToUTF16("1111"), credit_card->LastFourDigits());
EXPECT_EQ(base::ASCIIToUTF16("Bob Jones"),
credit_card->GetRawInfo(autofill::CREDIT_CARD_NAME_FULL));
+
+ // One instrument is available and selected.
+ EXPECT_EQ(1U, request->state()->available_instruments().size());
+ EXPECT_EQ(request->state()->available_instruments().back().get(),
+ request->state()->selected_instrument());
}
IN_PROC_BROWSER_TEST_F(PaymentRequestCreditCardEditorTest,
@@ -293,6 +303,11 @@ IN_PROC_BROWSER_TEST_F(PaymentRequestCreditCardEditorTest, EditingExpiredCard) {
InvokePaymentRequestUI();
+ // One instrument is available, but it's not selected.
+ PaymentRequest* request = GetPaymentRequests(GetActiveWebContents()).front();
+ EXPECT_EQ(1U, request->state()->available_instruments().size());
+ EXPECT_EQ(nullptr, request->state()->selected_instrument());
+
OpenPaymentMethodScreen();
ResetEventObserver(DialogEvent::CREDIT_CARD_EDITOR_OPENED);
@@ -336,6 +351,11 @@ IN_PROC_BROWSER_TEST_F(PaymentRequestCreditCardEditorTest, EditingExpiredCard) {
EXPECT_EQ(base::ASCIIToUTF16("4111111111111111"), credit_card->number());
EXPECT_EQ(base::ASCIIToUTF16("Test User"),
credit_card->GetRawInfo(autofill::CREDIT_CARD_NAME_FULL));
+
+ // Still have one instrument, but now it's selected.
+ EXPECT_EQ(1U, request->state()->available_instruments().size());
+ EXPECT_EQ(request->state()->available_instruments().back().get(),
+ request->state()->selected_instrument());
}
IN_PROC_BROWSER_TEST_F(PaymentRequestCreditCardEditorTest, EnteringEmptyData) {

Powered by Google App Engine
This is Rietveld 408576698