Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(839)

Issue 2807293004: [DevTools] Do not disable blocked URLs list when it's empty (Closed)

Created:
3 years, 8 months ago by dgozman
Modified:
3 years, 8 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Do not disable blocked URLs list when it's empty So that 'Add pattern' link continues to work. BUG=710349 TBR=pfeldman Review-Url: https://codereview.chromium.org/2807293004 Cr-Commit-Position: refs/heads/master@{#463765} Committed: https://chromium.googlesource.com/chromium/src/+/923a36a0089cff4f9e9ce2fa51809ab75ff3a749

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/devtools/front_end/network/BlockedURLsPane.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (7 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2807293004/1
3 years, 8 months ago (2017-04-11 20:49:56 UTC) #6
commit-bot: I haz the power
3 years, 8 months ago (2017-04-11 21:00:52 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/923a36a0089cff4f9e9ce2fa5180...

Powered by Google App Engine
This is Rietveld 408576698