third_party/WebKit/Source/devtools/front_end/network/BlockedURLsPane.js - Issue 2807293004: [DevTools] Do not disable blocked URLs list when it's empty

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/BlockedURLsPane.js

Issue 2807293004: [DevTools] Do not disable blocked URLs list when it's empty (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/devtools/front_end/network/BlockedURLsPane.js

diff --git a/third_party/WebKit/Source/devtools/front_end/network/BlockedURLsPane.js b/third_party/WebKit/Source/devtools/front_end/network/BlockedURLsPane.js

index 70daa6ec5be8c64cde1380dda64886780d1b4268..35c0f7343074f1550dde39cf3dca7f500faeb0ad 100644

--- a/third_party/WebKit/Source/devtools/front_end/network/BlockedURLsPane.js

+++ b/third_party/WebKit/Source/devtools/front_end/network/BlockedURLsPane.js

@@ -175,7 +175,7 @@ Network.BlockedURLsPane = class extends UI.VBox {

_update() {

var enabled = this._manager.blockingEnabled();

- this._list.element.classList.toggle('blocking-disabled', !enabled);

+ this._list.element.classList.toggle('blocking-disabled', !enabled && !!this._manager.blockedPatterns().length);

this._enabledCheckbox.setChecked(enabled);

this._list.clear();

for (var pattern of this._manager.blockedPatterns())

« no previous file with comments | « no previous file | no next file » | no next file with comments »