Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 2807183002: [Merge to 58]Fix body alignment for the desktop iOS promotion Bubble. (Closed)

Created:
3 years, 8 months ago by mrefaat
Modified:
3 years, 8 months ago
Reviewers:
sky
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

[Merge to 58]Fix body alignment for the desktop iOS promotion Bubble. This got broken by https://chromium.googlesource.com/chromium/src.git/+/623dc2bca68212e0f7e4617e84585a74fe63c7bc which was merged to m58 BUG=707289 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2800723003 Cr-Commit-Position: refs/heads/master@{#462560} (cherry picked from commit 9d291fab2615e3fcefba25e352dfab6e4fb0355f) Review-Url: https://codereview.chromium.org/2807183002 Cr-Commit-Position: refs/branch-heads/3029@{#646} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/e5057f1b8dc1fb10ba2d1af993e4ac59c7587bc0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -11 lines) Patch
M chrome/browser/ui/views/desktop_ios_promotion/desktop_ios_promotion_bubble_view.cc View 2 chunks +9 lines, -11 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
mrefaat
require LGTM as i'm not committer
3 years, 8 months ago (2017-04-10 15:37:25 UTC) #3
sky
LGTM
3 years, 8 months ago (2017-04-10 17:25:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2807183002/1
3 years, 8 months ago (2017-04-10 17:34:01 UTC) #6
commit-bot: I haz the power
CLs for remote refs other than refs/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
3 years, 8 months ago (2017-04-10 17:34:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2807183002/1
3 years, 8 months ago (2017-04-10 17:37:13 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-10 17:44:07 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e5057f1b8dc1fb10ba2d1af993e4...

Powered by Google App Engine
This is Rietveld 408576698