Fix body alignment for the desktop iOS promotion Bubble.

Fix body alignment for the desktop iOS promotion Bubble.

This got broken by https://chromium.googlesource.com/chromium/src.git/+/623dc2bca68212e0f7e4617e84585a74fe63c7bc
which was merged to m58


BUG=707289
Review-Url: https://codereview.chromium.org/2800723003
Cr-Commit-Position: refs/heads/master@{#462560}
Committed: https://chromium.googlesource.com/chromium/src/+/9d291fab2615e3fcefba25e352dfab6e4fb0355f

[mrefaat, 2017-04-05 20:58:20]

Description was changed from

==========
Fix body alignment for the desktop iOS promotion Bubble.

This got broken by
https://chromium.googlesource.com/chromium/src.git/+/623dc2bca68212e0f7e4617e...
which was merged to m58


BUG=707289
==========

to

==========
Fix body alignment for the desktop iOS promotion Bubble.

This got broken by
https://chromium.googlesource.com/chromium/src.git/+/623dc2bca68212e0f7e4617e...
which was merged to m58


BUG=707289
==========

[mrefaat, 2017-04-05 20:58:20]

mrefaat@chromium.org changed reviewers:
+ jasonkliu@chromium.org, sky@chromium.org

[sky, 2017-04-05 23:31:30]

https://codereview.chromium.org/2800723003/diff/1/chrome/browser/ui/views/des...
File
chrome/browser/ui/views/desktop_ios_promotion/desktop_ios_promotion_bubble_view.cc
(right):

https://codereview.chromium.org/2800723003/diff/1/chrome/browser/ui/views/des...
chrome/browser/ui/views/desktop_ios_promotion/desktop_ios_promotion_bubble_view.cc:40:
LayoutDelegate::Metric::PANEL_CONTENT_MARGIN) +
Are you sure you don't want to set a border on this with PANEL_CONTENT_MARGIN
all the way around?

[mrefaat, 2017-04-06 16:11:16]

https://codereview.chromium.org/2800723003/diff/1/chrome/browser/ui/views/des...
File
chrome/browser/ui/views/desktop_ios_promotion/desktop_ios_promotion_bubble_view.cc
(right):

https://codereview.chromium.org/2800723003/diff/1/chrome/browser/ui/views/des...
chrome/browser/ui/views/desktop_ios_promotion/desktop_ios_promotion_bubble_view.cc:40:
LayoutDelegate::Metric::PANEL_CONTENT_MARGIN) +
On 2017/04/05 23:31:30, sky wrote:
> Are you sure you don't want to set a border on this with PANEL_CONTENT_MARGIN
> all the way around?

sat it on sides, for the top and bottom it shouldn't be used as there is the
title margin and there is also some times the footnote. so they are usually set
up by the parent view.

[mrefaat, 2017-04-06 16:21:24]

Patchset #2 (id:20001) has been deleted

[mrefaat, 2017-04-06 16:22:53]

https://codereview.chromium.org/2800723003/diff/1/chrome/browser/ui/views/des...
File
chrome/browser/ui/views/desktop_ios_promotion/desktop_ios_promotion_bubble_view.cc
(right):

https://codereview.chromium.org/2800723003/diff/1/chrome/browser/ui/views/des...
chrome/browser/ui/views/desktop_ios_promotion/desktop_ios_promotion_bubble_view.cc:40:
LayoutDelegate::Metric::PANEL_CONTENT_MARGIN) +
On 2017/04/06 16:11:16, mrefaat wrote:
> On 2017/04/05 23:31:30, sky wrote:
> > Are you sure you don't want to set a border on this with
PANEL_CONTENT_MARGIN
> > all the way around?
> 
> sat it on sides, for the top and bottom it shouldn't be used as there is the
> title margin and there is also some times the footnote. so they are usually
set
> up by the parent view.

Actually when i did that i created too much space on the right of the bubble, it
seems that i only need that on the leading side. so i put it back to only the
left.

[sky, 2017-04-06 16:40:34]

LGTM

[mrefaat, 2017-04-06 16:41:52]

The CQ bit was checked by mrefaat@chromium.org

[commit-bot: I haz the power, 2017-04-06 16:42:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 18:47:22]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1491496912979460,
"parent_rev": "ca8dfa51db7ed68b7c8fca1ebc168539349a9675", "commit_rev":
"9d291fab2615e3fcefba25e352dfab6e4fb0355f"}

[commit-bot: I haz the power, 2017-04-06 18:48:38]

Description was changed from

==========
Fix body alignment for the desktop iOS promotion Bubble.

This got broken by
https://chromium.googlesource.com/chromium/src.git/+/623dc2bca68212e0f7e4617e...
which was merged to m58


BUG=707289
==========

to

==========
Fix body alignment for the desktop iOS promotion Bubble.

This got broken by
https://chromium.googlesource.com/chromium/src.git/+/623dc2bca68212e0f7e4617e...
which was merged to m58


BUG=707289

Review-Url: https://codereview.chromium.org/2800723003
Cr-Commit-Position: refs/heads/master@{#462560}
Committed:
https://chromium.googlesource.com/chromium/src/+/9d291fab2615e3fcefba25e352df...
==========

[commit-bot: I haz the power, 2017-04-06 18:48:39]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/9d291fab2615e3fcefba25e352df...