Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Issue 2800723003: Fix body alignment for the desktop iOS promotion Bubble. (Closed)

Created:
3 years, 8 months ago by mrefaat
Modified:
3 years, 8 months ago
Reviewers:
jasonkliu, sky
CC:
chromium-reviews, tfarina, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix body alignment for the desktop iOS promotion Bubble. This got broken by https://chromium.googlesource.com/chromium/src.git/+/623dc2bca68212e0f7e4617e84585a74fe63c7bc which was merged to m58 BUG=707289 Review-Url: https://codereview.chromium.org/2800723003 Cr-Commit-Position: refs/heads/master@{#462560} Committed: https://chromium.googlesource.com/chromium/src/+/9d291fab2615e3fcefba25e352dfab6e4fb0355f

Patch Set 1 #

Total comments: 3

Patch Set 2 : use insets #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -11 lines) Patch
M chrome/browser/ui/views/desktop_ios_promotion/desktop_ios_promotion_bubble_view.cc View 1 2 chunks +9 lines, -11 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (6 generated)
mrefaat
3 years, 8 months ago (2017-04-05 20:58:27 UTC) #3
mrefaat
3 years, 8 months ago (2017-04-05 20:58:27 UTC) #4
sky
https://codereview.chromium.org/2800723003/diff/1/chrome/browser/ui/views/desktop_ios_promotion/desktop_ios_promotion_bubble_view.cc File chrome/browser/ui/views/desktop_ios_promotion/desktop_ios_promotion_bubble_view.cc (right): https://codereview.chromium.org/2800723003/diff/1/chrome/browser/ui/views/desktop_ios_promotion/desktop_ios_promotion_bubble_view.cc#newcode40 chrome/browser/ui/views/desktop_ios_promotion/desktop_ios_promotion_bubble_view.cc:40: LayoutDelegate::Metric::PANEL_CONTENT_MARGIN) + Are you sure you don't want to ...
3 years, 8 months ago (2017-04-05 23:31:30 UTC) #5
mrefaat
https://codereview.chromium.org/2800723003/diff/1/chrome/browser/ui/views/desktop_ios_promotion/desktop_ios_promotion_bubble_view.cc File chrome/browser/ui/views/desktop_ios_promotion/desktop_ios_promotion_bubble_view.cc (right): https://codereview.chromium.org/2800723003/diff/1/chrome/browser/ui/views/desktop_ios_promotion/desktop_ios_promotion_bubble_view.cc#newcode40 chrome/browser/ui/views/desktop_ios_promotion/desktop_ios_promotion_bubble_view.cc:40: LayoutDelegate::Metric::PANEL_CONTENT_MARGIN) + On 2017/04/05 23:31:30, sky wrote: > Are ...
3 years, 8 months ago (2017-04-06 16:11:16 UTC) #6
mrefaat
https://codereview.chromium.org/2800723003/diff/1/chrome/browser/ui/views/desktop_ios_promotion/desktop_ios_promotion_bubble_view.cc File chrome/browser/ui/views/desktop_ios_promotion/desktop_ios_promotion_bubble_view.cc (right): https://codereview.chromium.org/2800723003/diff/1/chrome/browser/ui/views/desktop_ios_promotion/desktop_ios_promotion_bubble_view.cc#newcode40 chrome/browser/ui/views/desktop_ios_promotion/desktop_ios_promotion_bubble_view.cc:40: LayoutDelegate::Metric::PANEL_CONTENT_MARGIN) + On 2017/04/06 16:11:16, mrefaat wrote: > On ...
3 years, 8 months ago (2017-04-06 16:22:53 UTC) #8
sky
LGTM
3 years, 8 months ago (2017-04-06 16:40:34 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2800723003/40001
3 years, 8 months ago (2017-04-06 16:42:45 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 18:48:39 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/9d291fab2615e3fcefba25e352df...

Powered by Google App Engine
This is Rietveld 408576698