[regexp] Avoid side effects between map load and fast path check

[regexp] Avoid side effects between map load and fast path check

Loading the map, performing a side-effect, and then using the stored
pointer for the fast-path check is another antipattern that can lead to
unintended shapes on the fast path.

BUG=chromium:709029
Review-Url: https://codereview.chromium.org/2807153002
Cr-Commit-Position: refs/heads/master@{#44528}
Committed: https://chromium.googlesource.com/v8/v8/+/db61537afcbc4ed1914152aad302a9788bc80d0f

[jgruber, 2017-04-10 13:33:28]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-10 13:33:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2017-04-10 13:48:53]

jgruber@chromium.org changed reviewers:
+ yangguo@chromium.org

[commit-bot: I haz the power, 2017-04-10 14:02:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-10 14:02:26]

Dry run: This issue passed the CQ dry run.

[Yang, 2017-04-10 14:50:14]

On 2017/04/10 13:48:54, jgruber wrote:

lgtm!

[jgruber, 2017-04-10 14:51:41]

The CQ bit was checked by jgruber@chromium.org

[commit-bot: I haz the power, 2017-04-10 14:51:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 14:57:56]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1491835901357790, "parent_rev":
"038bafcb8c0435bc4130228237124331295d4713", "commit_rev":
"db61537afcbc4ed1914152aad302a9788bc80d0f"}

[commit-bot: I haz the power, 2017-04-10 14:58:01]

Description was changed from

==========
[regexp] Avoid side effects between map load and fast path check

Loading the map, performing a side-effect, and then using the stored
pointer for the fast-path check is another antipattern that can lead to
unintended shapes on the fast path.

BUG=chromium:709029
==========

to

==========
[regexp] Avoid side effects between map load and fast path check

Loading the map, performing a side-effect, and then using the stored
pointer for the fast-path check is another antipattern that can lead to
unintended shapes on the fast path.

BUG=chromium:709029

Review-Url: https://codereview.chromium.org/2807153002
Cr-Commit-Position: refs/heads/master@{#44528}
Committed:
https://chromium.googlesource.com/v8/v8/+/db61537afcbc4ed1914152aad302a9788bc...
==========

[commit-bot: I haz the power, 2017-04-10 14:58:02]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/db61537afcbc4ed1914152aad302a9788bc...