src/builtins/builtins-regexp-gen.h - Issue 2807153002: [regexp] Avoid side effects between map load and fast path check

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/builtins/builtins-regexp-gen.h

Issue 2807153002: [regexp] Avoid side effects between map load and fast path check (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/builtins/builtins-regexp-gen.h

diff --git a/src/builtins/builtins-regexp-gen.h b/src/builtins/builtins-regexp-gen.h

index eb4c117fc4155a23a7aeeeeef2649ab46e4fa6b7..8f82a9c125343345b27cfc17a9fa1889ef0dec12 100644

--- a/src/builtins/builtins-regexp-gen.h

+++ b/src/builtins/builtins-regexp-gen.h

@@ -59,7 +59,6 @@ class RegExpBuiltinsAssembler : public CodeStubAssembler {

// Analogous to BranchIfFastRegExp, for use in asserts.

Node* IsFastRegExp(Node* const context, Node* const object);

- Node* IsFastRegExp(Node* const context, Node* const object, Node* const map);

// Performs fast path checks on the given object itself, but omits prototype

// checks.

« no previous file with comments | « no previous file | src/builtins/builtins-regexp-gen.cc » ('j') | no next file with comments »