[instrumentation] Fix probe/BUILD.gn dependencies

[instrumentation] Fix probe/BUILD.gn dependencies

There are two targets. One for generating sources and another for compiling files.

BUG=709568
Review-Url: https://codereview.chromium.org/2807123005
Cr-Commit-Position: refs/heads/master@{#465070}
Committed: https://chromium.googlesource.com/chromium/src/+/63b2fd059db083da191d2dd9c53eb680baf2e010

[alph, 2017-04-12 04:53:12]

The CQ bit was checked by alph@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-12 04:53:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[alph, 2017-04-12 04:54:11]

alph@chromium.org changed reviewers:
+ pfeldman@chromium.org, slan@chromium.org

[alph, 2017-04-12 04:54:11]

ptal
this is a temp workaround for probes dependencies.

[commit-bot: I haz the power, 2017-04-12 06:52:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 06:52:20]

Dry run: This issue passed the CQ dry run.

[slan, 2017-04-12 14:08:32]

Thanks for making this change.

https://codereview.chromium.org/2807123005/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/probe/BUILD.gn (right):

https://codereview.chromium.org/2807123005/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/probe/BUILD.gn:57:
"//third_party/WebKit/Source/platform:make_platform_generated",
When we made this change locally a few days ago, I also needed a dependency on
"//third_party/WebKit/Source/core/inspector:protocol_sources". Does this target
need any generated protocol headers?

https://eureka-internal-review.git.corp.google.com/#/c/70989/1/third_party/We...

[pfeldman, 2017-04-13 00:31:48]

It seems like offending change can't be reverted?

[alph, 2017-04-13 01:17:05]

On 2017/04/13 00:31:48, pfeldman wrote:
> It seems like offending change can't be reverted?

Yes. I'll sort out the right set of dependencies as soon as I'm back.

[alph, 2017-04-13 19:54:59]

On 2017/04/13 01:17:05, alph_ooo wrote:
> On 2017/04/13 00:31:48, pfeldman wrote:
> > It seems like offending change can't be reverted?
> 
> Yes. I'll sort out the right set of dependencies as soon as I'm back.

Ptal

[alph, 2017-04-13 19:55:13]

The CQ bit was checked by alph@chromium.org

[commit-bot: I haz the power, 2017-04-13 19:55:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 19:55:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-13 19:55:58]

No L-G-T-M from a valid reviewer yet.
CQ run can only be started once the patch has received an L-G-T-M from a full
committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a
full super star committer.
Committers are members of the group "project-chromium-committers".
Note that this has nothing to do with OWNERS files.

[alph, 2017-04-14 01:41:10]

The CQ bit was checked by alph@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-14 01:41:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-14 05:36:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-14 05:36:02]

Dry run: This issue passed the CQ dry run.

[alph, 2017-04-17 21:48:10]

Description was changed from

==========
[instrumentation] Fix probe/BUILD.gn dependencies

A temporary workaround to fix missing dependencies.

BUG=709568
==========

to

==========
[instrumentation] Fix probe/BUILD.gn dependencies

There are two targets. One for generating sources and another for compiling
files.

BUG=709568
==========

[alph, 2017-04-17 21:48:17]

The CQ bit was checked by alph@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-17 21:48:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[alph, 2017-04-17 21:49:08]

I replaced the workaround with a proper fix. ptal

[slan, 2017-04-17 22:18:30]

l-g-t-m, but will defer to pfeldman.

[pfeldman, 2017-04-17 22:53:49]

lgtm

[commit-bot: I haz the power, 2017-04-17 23:55:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-17 23:55:48]

Dry run: This issue passed the CQ dry run.

[alph, 2017-04-18 00:00:29]

The CQ bit was checked by alph@chromium.org

[commit-bot: I haz the power, 2017-04-18 00:00:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 00:06:51]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1492473629906810,
"parent_rev": "2639037b06c07f5613640e1a5f5a98c5932cb8a0", "commit_rev":
"63b2fd059db083da191d2dd9c53eb680baf2e010"}

[commit-bot: I haz the power, 2017-04-18 00:07:24]

Description was changed from

==========
[instrumentation] Fix probe/BUILD.gn dependencies

There are two targets. One for generating sources and another for compiling
files.

BUG=709568
==========

to

==========
[instrumentation] Fix probe/BUILD.gn dependencies

There are two targets. One for generating sources and another for compiling
files.

BUG=709568

Review-Url: https://codereview.chromium.org/2807123005
Cr-Commit-Position: refs/heads/master@{#465070}
Committed:
https://chromium.googlesource.com/chromium/src/+/63b2fd059db083da191d2dd9c53e...
==========

[commit-bot: I haz the power, 2017-04-18 00:07:25]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/63b2fd059db083da191d2dd9c53e...