Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Unified Diff: third_party/WebKit/Source/core/probe/BUILD.gn

Issue 2807123005: [instrumentation] Fix probe/BUILD.gn dependencies (Closed)
Patch Set: proper fix Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/probe/BUILD.gn
diff --git a/third_party/WebKit/Source/core/probe/BUILD.gn b/third_party/WebKit/Source/core/probe/BUILD.gn
index 12ddeed8b23cbe53e8d3029a0c174c8c56b51898..b4a07cb640d9219431033d3c33fc4b78b7941784 100644
--- a/third_party/WebKit/Source/core/probe/BUILD.gn
+++ b/third_party/WebKit/Source/core/probe/BUILD.gn
@@ -4,13 +4,6 @@
import("//third_party/WebKit/Source/core/core.gni")
-blink_core_sources("probe") {
- sources = [
- "CoreProbes.cpp",
- "CoreProbes.h",
- ]
-}
-
action("instrumentation_probes") {
script = "../../build/scripts/make_instrumenting_probes.py"
@@ -37,21 +30,26 @@ action("instrumentation_probes") {
]
}
-# Compiles the sources generated above.
source_set("generated") {
- sources = get_target_outputs(":instrumentation_probes")
-
- configs -= core_config_remove
- configs +=
- core_config_add + [ "//third_party/WebKit/Source/core:core_include_dirs" ]
+ deps = [
+ ":instrumentation_probes",
+ ]
+}
- if (is_win) {
- cflags = [ "/wd4702" ] # Unreachable code.
- }
+# Compiles the sources generated above.
+blink_core_sources("probe") {
+ sources = [
+ "CoreProbes.cpp",
+ "CoreProbes.h",
+ ]
+ sources += get_target_outputs(":instrumentation_probes")
deps = [
":instrumentation_probes",
"//skia",
+ "//third_party/WebKit/Source/bindings/core/v8:bindings_core_v8_generated",
+ "//third_party/WebKit/Source/core:all_generators",
+ "//third_party/WebKit/Source/platform:make_platform_generated",
"//third_party/WebKit/Source/platform/wtf",
"//v8",
]
« no previous file with comments | « third_party/WebKit/Source/core/inspector/BUILD.gn ('k') | third_party/WebKit/Source/core/probe/CoreProbes.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698