Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 2807023003: [snapshot] encode resource before serializing. (Closed)

Created:
3 years, 8 months ago by Yang
Modified:
3 years, 8 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan, Yang
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[snapshot] encode resource before serializing. Before serializing an external string for a native source, we replace its resource field with the type and index of the native source. Upon deserialization, we restore the resource. This change also removes the native source caches with a more straight- forward mechanism to find the resource type and index. R=ulan@chromium.org Review-Url: https://codereview.chromium.org/2807023003 Cr-Commit-Position: refs/heads/master@{#44545} Committed: https://chromium.googlesource.com/v8/v8/+/7a8d20a79f9d5ce6fe589477b09327f3e90bf0e0

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : fix leak #

Patch Set 4 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -239 lines) Patch
M src/bootstrapper.h View 3 chunks +2 lines, -16 lines 0 comments Download
M src/bootstrapper.cc View 1 2 5 chunks +11 lines, -51 lines 0 comments Download
M src/heap/heap.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M src/heap/heap.cc View 1 1 chunk +0 lines, -10 lines 0 comments Download
M src/snapshot/deserializer.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/snapshot/deserializer.cc View 1 2 3 chunks +8 lines, -20 lines 0 comments Download
M src/snapshot/natives.h View 1 2 3 3 chunks +32 lines, -4 lines 0 comments Download
M src/snapshot/natives-common.cc View 1 chunk +23 lines, -15 lines 0 comments Download
M src/snapshot/serializer.h View 2 chunks +1 line, -4 lines 0 comments Download
M src/snapshot/serializer.cc View 2 chunks +46 lines, -81 lines 0 comments Download
M src/snapshot/serializer-common.h View 2 chunks +4 lines, -10 lines 0 comments Download
M test/cctest/test-serialize.cc View 3 chunks +0 lines, -21 lines 0 comments Download

Messages

Total messages: 20 (11 generated)
Yang
3 years, 8 months ago (2017-04-10 08:36:07 UTC) #1
ulan
lgtm
3 years, 8 months ago (2017-04-10 11:50:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2807023003/1
3 years, 8 months ago (2017-04-10 11:51:38 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/builds/16527)
3 years, 8 months ago (2017-04-10 11:56:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2807023003/40001
3 years, 8 months ago (2017-04-11 04:57:05 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/builds/16598)
3 years, 8 months ago (2017-04-11 05:02:15 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2807023003/50013
3 years, 8 months ago (2017-04-11 05:23:27 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2807023003/50013
3 years, 8 months ago (2017-04-11 05:36:47 UTC) #17
commit-bot: I haz the power
3 years, 8 months ago (2017-04-11 05:46:56 UTC) #20
Message was sent while issue was closed.
Committed patchset #4 (id:50013) as
https://chromium.googlesource.com/v8/v8/+/7a8d20a79f9d5ce6fe589477b09327f3e90...

Powered by Google App Engine
This is Rietveld 408576698