🔍 Hide the Google G by default

🔍 Hide the Google G by default

Inflate the logo inside of the LocationBarPhone instead
of having it always be inflated for LocationBar subclasses.
This is more efficient and slightly harder to break than
the solution we'd discussed offline, where the FrameLayout
was just set to View.GONE initially.

I might have to follow up eventually™ with a CL to make the
visibility checks more robust later on.

BUG=708844
Review-Url: https://codereview.chromium.org/2806753003
Cr-Commit-Position: refs/heads/master@{#463087}
Committed: https://chromium.googlesource.com/chromium/src/+/1204d2395bf8818c777c3af005f046b9d11036b9

[gone, 2017-04-07 22:14:04]

Description was changed from

==========
🔍 Hide the Google G by default

Set it to be GONE during inflation.  The calculation for its
visibility is appropriately updated when needed for the NTP.

Longer term, this should probably be pushed down into some
layout that is tailored for LocationBarPhone, or pushed into
a ViewStub that is inflated only when the LocationBarPhone
deems that it is needed.

BUG=708844
==========

to

==========
🔍 Hide the Google G by default

Make it impossible to see the Google G outside
of the LocationBarPhone.  The current implementation
pushes the whole thing into a sub layout that is
inflated via a ViewStub when it is needed.

BUG=708844
==========

[gone, 2017-04-07 22:20:23]

Description was changed from

==========
🔍 Hide the Google G by default

Make it impossible to see the Google G outside
of the LocationBarPhone.  The current implementation
pushes the whole thing into a sub layout that is
inflated via a ViewStub when it is needed.

BUG=708844
==========

to

==========
🔍 Hide the Google G by default

Inflate the logo inside of the LocationBarPhone instead
of having it always be inflated for LocationBar subclasses.
This is more efficient and slightly harder to break than
the solution we'd discussed offline, where the FrameLayout
was just set to View.GONE initially.

I might have to follow up eventually™ with a CL to make the
visibility checks more robust later on.

BUG=708844
==========

[gone, 2017-04-07 22:23:50]

dfalcantara@chromium.org changed reviewers:
+ bauerb@chromium.org, peconn@chromium.org

[gone, 2017-04-07 22:23:50]

What do you guys think about this?  I was initially going to just hide the
FrameLayout, but then it'd still be dangling there in the layout taking up
resources (Patch Set 1).  I moved it over to a ViewStub implementation (Patch
Set 2) instead so that it just gets inflated when it's needed.  Makes it a lot
harder to show it if it's not even in the layout to begin with.

[gone, 2017-04-07 22:28:35]

The CQ bit was checked by dfalcantara@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-07 22:29:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bernhard Bauer, 2017-04-07 22:49:26]

lgtm

[commit-bot: I haz the power, 2017-04-07 22:52:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-07 22:52:15]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[gone, 2017-04-07 22:55:11]

The CQ bit was checked by dfalcantara@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-07 22:55:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gone, 2017-04-07 22:59:37]

The CQ bit was checked by dfalcantara@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-07 23:00:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gone, 2017-04-07 23:58:13]

The CQ bit was unchecked by dfalcantara@chromium.org

[gone, 2017-04-07 23:58:14]

The CQ bit was checked by dfalcantara@chromium.org

[gone, 2017-04-07 23:58:15]

The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org
Link to the patchset: https://codereview.chromium.org/2806753003/#ps40001
(title: "🔍 Hide the Google G by default")

[gone, 2017-04-07 23:58:19]

The CQ bit was checked by dfalcantara@chromium.org

[commit-bot: I haz the power, 2017-04-07 23:58:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-08 01:00:36]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1491609499474300,
"parent_rev": "510e22f9f39070b901c526fe5b04079cb30b48af", "commit_rev":
"1204d2395bf8818c777c3af005f046b9d11036b9"}

[commit-bot: I haz the power, 2017-04-08 01:01:27]

Description was changed from

==========
🔍 Hide the Google G by default

Inflate the logo inside of the LocationBarPhone instead
of having it always be inflated for LocationBar subclasses.
This is more efficient and slightly harder to break than
the solution we'd discussed offline, where the FrameLayout
was just set to View.GONE initially.

I might have to follow up eventually™ with a CL to make the
visibility checks more robust later on.

BUG=708844
==========

to

==========
🔍 Hide the Google G by default

Inflate the logo inside of the LocationBarPhone instead
of having it always be inflated for LocationBar subclasses.
This is more efficient and slightly harder to break than
the solution we'd discussed offline, where the FrameLayout
was just set to View.GONE initially.

I might have to follow up eventually™ with a CL to make the
visibility checks more robust later on.

BUG=708844

Review-Url: https://codereview.chromium.org/2806753003
Cr-Commit-Position: refs/heads/master@{#463087}
Committed:
https://chromium.googlesource.com/chromium/src/+/1204d2395bf8818c777c3af005f0...
==========

[commit-bot: I haz the power, 2017-04-08 01:01:31]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/1204d2395bf8818c777c3af005f0...