Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1055)

Issue 2799343005: 🔍 Switch to using the generic LocationBarLayout (Closed)

Created:
3 years, 8 months ago by gone
Modified:
3 years, 8 months ago
Reviewers:
Yusuf
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

🔍 Switch to using the generic LocationBarLayout Tablet devices don't like using the LocationBarPhone. Switch to using the LocationBarLayout as a generic class again. BUG=708844 Review-Url: https://codereview.chromium.org/2799343005 Cr-Commit-Position: refs/heads/master@{#463042} Committed: https://chromium.googlesource.com/chromium/src/+/8f5e90160be0556460c03c7cdfb91dd10016af28

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchActivityLocationBarLayout.java View 2 chunks +3 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 20 (12 generated)
gone
3 years, 8 months ago (2017-04-07 19:59:56 UTC) #2
Yusuf
lgtm
3 years, 8 months ago (2017-04-07 20:06:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2799343005/1
3 years, 8 months ago (2017-04-07 20:11:38 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/405817)
3 years, 8 months ago (2017-04-07 20:21:09 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2799343005/1
3 years, 8 months ago (2017-04-07 20:37:25 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/405854)
3 years, 8 months ago (2017-04-07 20:45:48 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2799343005/1
3 years, 8 months ago (2017-04-07 22:22:49 UTC) #17
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 23:20:30 UTC) #20
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8f5e90160be0556460c03c7cdfb9...

Powered by Google App Engine
This is Rietveld 408576698