Image Capture: split {white_balance,exposure,focus}_modes into current_ and supported_

Image Capture: split {white_balance,exposure,focus}_mode into current_ and supported_

|This CL splits mojo |{white_balance,exposure,focus}_mode|
into |current_{white_balance,exposure,focus}_mode| and an
array of |supported_{white_balance,exposure,focus}_modes|.

The |current_...| versions are essentially the same as the
previous variables, with a twist: if there are no 
|supported_...| entries, then there can be no |current_...|.
(This prevents the capabilities dictionary from having 
superfluous entries).

LayoutTests, Fake capture device and V4L2 implementations are
updated. (Will do the Android parts in another CL to ease
review).

Also I reordered the fields of mock-imagecapture.js |state_| 
to match .mojom definition order because it was driving me
nuts to compare both :-)


BUG=700607
Review-Url: https://codereview.chromium.org/2806743003
Cr-Commit-Position: refs/heads/master@{#463116}
Committed: https://chromium.googlesource.com/chromium/src/+/7aafd1384fd8c6dc46d85d0cec98e85c480bd464

[mcasas, 2017-04-07 23:26:48]

Description was changed from

==========
Image Capture: split modes

Renamed |bla_mode| to |current_bla_mode| in image_capture.mojom and updated
everywhere


Reordered fields of mock-imagecapture.js |state_| to match .mojom definition
order

BUG=700607
==========

to

==========
Image Capture: split {white_balance,exposure,focus}_mode into current_ and
supported_

|This CL splits mojo |{white_balance,exposure,focus}_mode|
into |current_{white_balance,exposure,focus}_mode| and an
array of |supported_{white_balance,exposure,focus}_modes|.


LayoutTests, Fake capture device and V4L2 implementations are
updated.

Also I reordered the fields of mock-imagecapture.js |state_| 
to match .mojom definition order because it was driving me
nuts to compare both :-)


BUG=700607
==========

[mcasas, 2017-04-07 23:28:00]

Description was changed from

==========
Image Capture: split {white_balance,exposure,focus}_mode into current_ and
supported_

|This CL splits mojo |{white_balance,exposure,focus}_mode|
into |current_{white_balance,exposure,focus}_mode| and an
array of |supported_{white_balance,exposure,focus}_modes|.


LayoutTests, Fake capture device and V4L2 implementations are
updated.

Also I reordered the fields of mock-imagecapture.js |state_| 
to match .mojom definition order because it was driving me
nuts to compare both :-)


BUG=700607
==========

to

==========
Image Capture: split {white_balance,exposure,focus}_mode into current_ and
supported_

|This CL splits mojo |{white_balance,exposure,focus}_mode|
into |current_{white_balance,exposure,focus}_mode| and an
array of |supported_{white_balance,exposure,focus}_modes|.

The current_... versions are essentially the same as the
previous variables, while the supported_... is mostly new.

LayoutTests, Fake capture device and V4L2 implementations are
updated.

Also I reordered the fields of mock-imagecapture.js |state_| 
to match .mojom definition order because it was driving me
nuts to compare both :-)


BUG=700607
==========

[mcasas, 2017-04-07 23:31:52]

Description was changed from

==========
Image Capture: split {white_balance,exposure,focus}_mode into current_ and
supported_

|This CL splits mojo |{white_balance,exposure,focus}_mode|
into |current_{white_balance,exposure,focus}_mode| and an
array of |supported_{white_balance,exposure,focus}_modes|.

The current_... versions are essentially the same as the
previous variables, while the supported_... is mostly new.

LayoutTests, Fake capture device and V4L2 implementations are
updated.

Also I reordered the fields of mock-imagecapture.js |state_| 
to match .mojom definition order because it was driving me
nuts to compare both :-)


BUG=700607
==========

to

==========
Image Capture: split {white_balance,exposure,focus}_mode into current_ and
supported_

|This CL splits mojo |{white_balance,exposure,focus}_mode|
into |current_{white_balance,exposure,focus}_mode| and an
array of |supported_{white_balance,exposure,focus}_modes|.

The |current_...| versions are essentially the same as the
previous variables, with a twist: if there are no 
|supported_...| entries, then there can be no |current_...|.
(This prevents the capabilities dictionary from having 
superfluous entries).

LayoutTests, Fake capture device and V4L2 implementations are
updated.

Also I reordered the fields of mock-imagecapture.js |state_| 
to match .mojom definition order because it was driving me
nuts to compare both :-)


BUG=700607
==========

[mcasas, 2017-04-07 23:32:44]

Patchset #1 (id:1) has been deleted

[mcasas, 2017-04-07 23:32:49]

Patchset #1 (id:20001) has been deleted

[mcasas, 2017-04-07 23:32:55]

Patchset #1 (id:40001) has been deleted

[mcasas, 2017-04-07 23:34:51]

Description was changed from

==========
Image Capture: split {white_balance,exposure,focus}_mode into current_ and
supported_

|This CL splits mojo |{white_balance,exposure,focus}_mode|
into |current_{white_balance,exposure,focus}_mode| and an
array of |supported_{white_balance,exposure,focus}_modes|.

The |current_...| versions are essentially the same as the
previous variables, with a twist: if there are no 
|supported_...| entries, then there can be no |current_...|.
(This prevents the capabilities dictionary from having 
superfluous entries).

LayoutTests, Fake capture device and V4L2 implementations are
updated.

Also I reordered the fields of mock-imagecapture.js |state_| 
to match .mojom definition order because it was driving me
nuts to compare both :-)


BUG=700607
==========

to

==========
Image Capture: split {white_balance,exposure,focus}_mode into current_ and
supported_

|This CL splits mojo |{white_balance,exposure,focus}_mode|
into |current_{white_balance,exposure,focus}_mode| and an
array of |supported_{white_balance,exposure,focus}_modes|.

The |current_...| versions are essentially the same as the
previous variables, with a twist: if there are no 
|supported_...| entries, then there can be no |current_...|.
(This prevents the capabilities dictionary from having 
superfluous entries).

LayoutTests, Fake capture device and V4L2 implementations are
updated. (Will do the Android parts in another CL to ease
review).

Also I reordered the fields of mock-imagecapture.js |state_| 
to match .mojom definition order because it was driving me
nuts to compare both :-)


BUG=700607
==========

[mcasas, 2017-04-07 23:35:03]

Patchset #1 (id:60001) has been deleted

[mcasas, 2017-04-07 23:36:43]

mcasas@chromium.org changed reviewers:
+ reillyg@chromium.org, tsepez@chromium.org

[mcasas, 2017-04-07 23:36:44]

reillyg@ PTAL

tsepez@ RS plz the additions to image_capture.mojom


(Almost there! Just one or two extra CLs and
we'll ship!!!!)

[Tom Sepez, 2017-04-07 23:38:23]

RS LGTM

[Reilly Grant (use Gerrit), 2017-04-08 00:30:52]

https://codereview.chromium.org/2806743003/diff/80001/media/capture/video/lin...
File media/capture/video/linux/v4l2_capture_delegate.cc (right):

https://codereview.chromium.org/2806743003/diff/80001/media/capture/video/lin...
media/capture/video/linux/v4l2_capture_delegate.cc:557: if
(RunIoctl(device_fd_.get(), VIDIOC_QUERYCTRL, &manual_focus_ctrl))
This function didn't previously use RunIoctl. I'm nervous about using this here
where we expect the ioctl to return a failure which means that it will always
run kMaxIOCtrlRetries times.

https://codereview.chromium.org/2806743003/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp (right):

https://codereview.chromium.org/2806743003/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp:530:
WTF::Vector<WTF::String> supportedWhiteBalanceModes;
Before copying into these new vectors reserve the necessary capacity.

[mcasas, 2017-04-08 00:50:47]

ptal

https://codereview.chromium.org/2806743003/diff/80001/media/capture/video/lin...
File media/capture/video/linux/v4l2_capture_delegate.cc (right):

https://codereview.chromium.org/2806743003/diff/80001/media/capture/video/lin...
media/capture/video/linux/v4l2_capture_delegate.cc:557: if
(RunIoctl(device_fd_.get(), VIDIOC_QUERYCTRL, &manual_focus_ctrl))
On 2017/04/08 00:30:52, Reilly Grant wrote:
> This function didn't previously use RunIoctl. I'm nervous about using this
here
> where we expect the ioctl to return a failure which means that it will always
> run kMaxIOCtrlRetries times.

It did use RunIoctl() before, but it's hidden inside
RetrieveUserControlRange() [1], called in e.g. l.630
and vicinity.

Out of experience, QUERYCTRLs for these newly added 
capabilities tend to succeed, and the failures appear 
while resetting the controls.


[1]
https://cs.chromium.org/chromium/src/media/capture/video/linux/v4l2_capture_d...

https://codereview.chromium.org/2806743003/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp (right):

https://codereview.chromium.org/2806743003/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp:530:
WTF::Vector<WTF::String> supportedWhiteBalanceModes;
On 2017/04/08 00:30:52, Reilly Grant wrote:
> Before copying into these new vectors reserve the necessary capacity.

Done.

[Reilly Grant (use Gerrit), 2017-04-08 00:56:44]

lgtm

[mcasas, 2017-04-08 02:23:49]

The CQ bit was checked by mcasas@chromium.org

[mcasas, 2017-04-08 02:23:50]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/2806743003/#ps100001
(title: "reillyg@ comment and fix in v4l2_capture_delegate.cc")

[commit-bot: I haz the power, 2017-04-08 02:24:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-08 03:03:32]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1491618229853810,
"parent_rev": "e1197d0eff5daafdcd8f4991c6eb24c87b39c9ca", "commit_rev":
"7aafd1384fd8c6dc46d85d0cec98e85c480bd464"}

[commit-bot: I haz the power, 2017-04-08 03:04:14]

Description was changed from

==========
Image Capture: split {white_balance,exposure,focus}_mode into current_ and
supported_

|This CL splits mojo |{white_balance,exposure,focus}_mode|
into |current_{white_balance,exposure,focus}_mode| and an
array of |supported_{white_balance,exposure,focus}_modes|.

The |current_...| versions are essentially the same as the
previous variables, with a twist: if there are no 
|supported_...| entries, then there can be no |current_...|.
(This prevents the capabilities dictionary from having 
superfluous entries).

LayoutTests, Fake capture device and V4L2 implementations are
updated. (Will do the Android parts in another CL to ease
review).

Also I reordered the fields of mock-imagecapture.js |state_| 
to match .mojom definition order because it was driving me
nuts to compare both :-)


BUG=700607
==========

to

==========
Image Capture: split {white_balance,exposure,focus}_mode into current_ and
supported_

|This CL splits mojo |{white_balance,exposure,focus}_mode|
into |current_{white_balance,exposure,focus}_mode| and an
array of |supported_{white_balance,exposure,focus}_modes|.

The |current_...| versions are essentially the same as the
previous variables, with a twist: if there are no 
|supported_...| entries, then there can be no |current_...|.
(This prevents the capabilities dictionary from having 
superfluous entries).

LayoutTests, Fake capture device and V4L2 implementations are
updated. (Will do the Android parts in another CL to ease
review).

Also I reordered the fields of mock-imagecapture.js |state_| 
to match .mojom definition order because it was driving me
nuts to compare both :-)


BUG=700607

Review-Url: https://codereview.chromium.org/2806743003
Cr-Commit-Position: refs/heads/master@{#463116}
Committed:
https://chromium.googlesource.com/chromium/src/+/7aafd1384fd8c6dc46d85d0cec98...
==========

[commit-bot: I haz the power, 2017-04-08 03:04:15]

Committed patchset #2 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/7aafd1384fd8c6dc46d85d0cec98...