media/capture/video/fake_video_capture_device_unittest.cc - Issue 2806743003: Image Capture: split {white_balance,exposure,focus}_modes into current_ and supported_

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/capture/video/fake_video_capture_device_unittest.cc

Issue 2806743003: Image Capture: split {white_balance,exposure,focus}_modes into current_ and supported_ (Closed)

Patch Set: reillyg@ comment and fix in v4l2_capture_delegate.cc Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/capture/video/fake_video_capture_device_unittest.cc

diff --git a/media/capture/video/fake_video_capture_device_unittest.cc b/media/capture/video/fake_video_capture_device_unittest.cc

index bd57e1536f0057ffadd4574b55840befcb3141fa..a0999ad5216ec89e58497a9a8dff3e4a50dd022f 100644

--- a/media/capture/video/fake_video_capture_device_unittest.cc

+++ b/media/capture/video/fake_video_capture_device_unittest.cc

@@ -425,9 +425,10 @@ TEST_F(FakeVideoCaptureDeviceTest, GetAndSetCapabilities) {

const mojom::PhotoCapabilities* capabilities =

image_capture_client_->capabilities();

ASSERT_TRUE(capabilities);

- EXPECT_EQ(mojom::MeteringMode::NONE, capabilities->white_balance_mode);

- EXPECT_EQ(mojom::MeteringMode::NONE, capabilities->exposure_mode);

- EXPECT_EQ(mojom::MeteringMode::NONE, capabilities->focus_mode);

+ EXPECT_EQ(mojom::MeteringMode::NONE,

+ capabilities->current_white_balance_mode);

+ EXPECT_EQ(mojom::MeteringMode::NONE, capabilities->current_exposure_mode);

+ EXPECT_EQ(mojom::MeteringMode::NONE, capabilities->current_focus_mode);

EXPECT_EQ(0, capabilities->exposure_compensation->min);

EXPECT_EQ(0, capabilities->exposure_compensation->max);