Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Unified Diff: components/crash/content/app/breakpad_linux.cc

Issue 2806733002: aw: Fix multiprocess flag usage (Closed)
Patch Set: Also fix breakpad component so that single process microdump ptype is right. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/crash/content/app/breakpad_linux.cc
diff --git a/components/crash/content/app/breakpad_linux.cc b/components/crash/content/app/breakpad_linux.cc
index 036424c8368ce07c18eef7f3d03a676c1c78d8a5..0d3de65043a0b66fc1d3bc8fee578ae13179f611 100644
--- a/components/crash/content/app/breakpad_linux.cc
+++ b/components/crash/content/app/breakpad_linux.cc
@@ -1951,7 +1951,14 @@ void InitCrashReporter(const std::string& process_type) {
if (parsed_command_line.HasSwitch(switches::kDisableBreakpad))
return;
- if (process_type.empty()) {
+ bool is_browser_process =
+#if defined(OS_ANDROID)
+ process_type == kWebViewSingleProcessType ||
+ process_type == kBrowserProcessType ||
Torne 2017/04/10 14:06:29 How annoying would it be to change all the uses of
Tobias Sargeant 2017/04/10 14:21:14 It seems like it would be worth it. It's not our c
Robert Sesek 2017/04/10 15:17:18 The process_type.empty() meaning browser is a bake
+#endif
+ process_type.empty();
+
+ if (is_browser_process) {
bool enable_breakpad = GetCrashReporterClient()->GetCollectStatsConsent() ||
GetCrashReporterClient()->IsRunningUnattended();
enable_breakpad &=

Powered by Google App Engine
This is Rietveld 408576698