aw: Fix multiprocess flag usage

components/crash/content/app/breakpad_linux.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // For linux_syscall_support.h. This makes it safe to call embedded system
 // calls when in seccomp mode.
 
 #include "components/crash/content/app/breakpad_linux.h"
 
 #include <fcntl.h>
@@ skipping 1933 matching lines @@
   // that if conventional minidump crash reporting is enabled below, it takes
   // precedence (i.e. its handler is run first) over the microdump handler.
   InitMicrodumpCrashHandlerIfNecessary(process_type, sanitization_info);
 #endif
   // Determine the process type and take appropriate action.
   const base::CommandLine& parsed_command_line =
       *base::CommandLine::ForCurrentProcess();
   if (parsed_command_line.HasSwitch(switches::kDisableBreakpad))
     return;
 
-  if (process_type.empty()) {
+  bool is_browser_process =
+#if defined(OS_ANDROID)
+      process_type == kWebViewSingleProcessType ||
+      process_type == kBrowserProcessType ||

[Torne, 2017/04/10 14:06:29]

How annoying would it be to change all the uses of empty string to "browser" so
this isn't OS-specific? (maybe not in this change since I assume we're going to
pick this to 58) Worth it?

[Tobias Sargeant, 2017/04/10 14:21:14]

It seems like it would be worth it. It's not our code though. I'm pretty sure
this CL removes the last webview use of "" as a process type.

I'll take a look with lower priority.

[Robert Sesek, 2017/04/10 15:17:18]

The process_type.empty() meaning browser is a baked-in assumption of Chrome,
since it stems from the fact that the browser process has no --type= switch.
Whether or not that's worth changing at the crash reporting level is debatable.

+#endif
+      process_type.empty();
+
+  if (is_browser_process) {
     bool enable_breakpad = GetCrashReporterClient()->GetCollectStatsConsent() ||
                            GetCrashReporterClient()->IsRunningUnattended();
     enable_breakpad &=
         !parsed_command_line.HasSwitch(switches::kDisableBreakpad);
     if (!enable_breakpad) {
       enable_breakpad = parsed_command_line.HasSwitch(
           switches::kEnableCrashReporterForTesting);
     }
     if (!enable_breakpad) {
       VLOG(1) << "Breakpad disabled";
@@ skipping 114 matching lines @@
 void SuppressDumpGeneration() {
   g_dumps_suppressed = G_DUMPS_SUPPRESSED_MAGIC;
 }
 #endif  // OS_ANDROID
 
 bool IsCrashReporterEnabled() {
   return g_is_crash_reporter_enabled;
 }
 
 }  // namespace breakpad