Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1800)

Unified Diff: android_webview/browser/aw_content_browser_client.cc

Issue 2806733002: aw: Fix multiprocess flag usage (Closed)
Patch Set: Also fix breakpad component so that single process microdump ptype is right. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/browser/aw_content_browser_client.cc
diff --git a/android_webview/browser/aw_content_browser_client.cc b/android_webview/browser/aw_content_browser_client.cc
index 45ab2d0ce581af72e9fa06c486b40e243a07956e..749d724459f102e1bfce9489f97f4c998b971390 100644
--- a/android_webview/browser/aw_content_browser_client.cc
+++ b/android_webview/browser/aw_content_browser_client.cc
@@ -270,9 +270,7 @@ bool AwContentBrowserClient::IsHandledURL(const GURL& url) {
void AwContentBrowserClient::AppendExtraCommandLineSwitches(
base::CommandLine* command_line,
int child_process_id) {
- if (command_line->HasSwitch(switches::kSingleProcess)) {
- NOTREACHED() << "Android WebView does not support multi-process yet";
Torne 2017/04/10 14:06:29 This is pretty weird; I assume we never reached th
Tobias Sargeant 2017/04/10 14:21:14 Since kSingleProcess was never set, I presume we n
- } else {
+ if (command_line->HasSwitch(switches::kWebViewSandboxedRenderer)) {
// The only kind of a child process WebView can have is renderer.
DCHECK_EQ(switches::kRendererProcess,
command_line->GetSwitchValueASCII(switches::kProcessType));

Powered by Google App Engine
This is Rietveld 408576698