aw: Fix multiprocess flag usage

android_webview/browser/aw_content_browser_client.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "android_webview/browser/aw_content_browser_client.h"
 
 #include <utility>
 
 #include "android_webview/browser/aw_browser_context.h"
 #include "android_webview/browser/aw_browser_main_parts.h"
@@ skipping 252 matching lines @@
   for (size_t i = 0; i < arraysize(kProtocolList); ++i) {
     if (scheme == kProtocolList[i])
       return true;
   }
   return net::URLRequest::IsHandledProtocol(scheme);
 }
 
 void AwContentBrowserClient::AppendExtraCommandLineSwitches(
     base::CommandLine* command_line,
     int child_process_id) {
-  if (command_line->HasSwitch(switches::kSingleProcess)) {
-    NOTREACHED() << "Android WebView does not support multi-process yet";

[Torne, 2017/04/10 14:06:29]

This is pretty weird; I assume we never reached this line? The message seems
misleading. I'm okay with removing it since it doesn't seem to be accomplishing
anything, but if you figured out why this was here in the first place I'm
curious :)

[Tobias Sargeant, 2017/04/10 14:21:14]

Since kSingleProcess was never set, I presume we never reached this.

The message itself goes way back (2012) and was unconditional. Mikhail added the
condition. I don't quite understand the point, because it seems like this method
is only be called when we're going to start a child process.

-  } else {
+  if (command_line->HasSwitch(switches::kWebViewSandboxedRenderer)) {
     // The only kind of a child process WebView can have is renderer.
     DCHECK_EQ(switches::kRendererProcess,
               command_line->GetSwitchValueASCII(switches::kProcessType));
     // Pass crash reporter enabled state to renderer processes.
     if (crash_reporter::IsCrashReporterEnabled()) {
       command_line->AppendSwitch(::switches::kEnableCrashReporter);
     }
   }
 }
 
@@ skipping 277 matching lines @@
                  render_frame_host));
 
   // Although WebView does not support password manager feature, renderer code
   // could still request this interface, so we register a dummy binder which
   // just drops the incoming request, to avoid the 'Failed to locate a binder
   // for interface' error log..
   registry->AddInterface(base::Bind(&DummyBindPasswordManagerDriver));
 }
 
 }  // namespace android_webview