Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2806713002: Some minor fixes for Background Fetch (Closed)

Created:
3 years, 8 months ago by Peter Beverloo
Modified:
3 years, 8 months ago
CC:
chromium-reviews, wjmaclean, awdf+watch_chromium.org, Peter Beverloo, jam, blink-reviews, darin-cc_chromium.org, haraken, harkness+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Some minor fixes for Background Fetch - Initialize the URL request context getter on the IO thread. - Initialize the response type to Default to match a DCHECK. - Don't double initialize the fetches in BackgroundFetchedEvent BUG=692579 Review-Url: https://codereview.chromium.org/2806713002 Cr-Commit-Position: refs/heads/master@{#462868} Committed: https://chromium.googlesource.com/chromium/src/+/a341a03cb3c251ef8c43d76fce50c77e6abd69bc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -8 lines) Patch
M content/browser/background_fetch/background_fetch_context.h View 2 chunks +6 lines, -1 line 0 comments Download
M content/browser/background_fetch/background_fetch_context.cc View 2 chunks +8 lines, -4 lines 0 comments Download
M content/browser/background_fetch/background_fetch_data_manager.cc View 2 chunks +3 lines, -1 line 0 comments Download
M content/browser/background_fetch/background_fetch_service_unittest.cc View 2 chunks +4 lines, -1 line 0 comments Download
M content/browser/storage_partition_impl_map.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/background_fetch/BackgroundFetchedEvent.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (9 generated)
Peter Beverloo
+miguelg for background fetch +avi for storage_partition_impl_map.cc tldr - the URL request context getter is ...
3 years, 8 months ago (2017-04-07 12:35:24 UTC) #5
Miguel Garcia
lgtm
3 years, 8 months ago (2017-04-07 13:00:56 UTC) #6
Avi (use Gerrit)
lgtm stamp
3 years, 8 months ago (2017-04-07 15:34:49 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2806713002/1
3 years, 8 months ago (2017-04-07 15:36:37 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 15:42:13 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a341a03cb3c251ef8c43d76fce50...

Powered by Google App Engine
This is Rietveld 408576698