Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(546)

Issue 2805813006: Set the Content-Type and Content-Length headers for BG Fetch (Closed)

Created:
3 years, 8 months ago by Peter Beverloo
Modified:
3 years, 8 months ago
Reviewers:
Miguel Garcia
CC:
chromium-reviews, Peter Beverloo, darin-cc_chromium.org, jam, harkness+watch_chromium.org, awdf+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Set the Content-Type and Content-Length headers for BG Fetch While we work on being able to relay all response headers from the download system to the created Response object for Background Fetch, these two will enable some minimum experimentation. BUG=692579, 709489 Review-Url: https://codereview.chromium.org/2805813006 Cr-Commit-Position: refs/heads/master@{#462899} Committed: https://chromium.googlesource.com/chromium/src/+/f25963e5ad7ca9e19db5ac255e4225145593e221

Patch Set 1 #

Patch Set 2 : Set the Content-Type and Content-Length headers for BG Fetch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -4 lines) Patch
M content/browser/background_fetch/background_fetch_data_manager.cc View 2 chunks +16 lines, -2 lines 0 comments Download
M content/browser/background_fetch/background_fetch_request_info.h View 2 chunks +4 lines, -0 lines 0 comments Download
M content/browser/background_fetch/background_fetch_request_info.cc View 1 2 chunks +6 lines, -0 lines 0 comments Download
M content/browser/background_fetch/background_fetch_service_unittest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/background_fetch/background_fetch_test_base.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (6 generated)
Miguel Garcia
lgtm I wonder if you should create a bug for relaying the headers and the ...
3 years, 8 months ago (2017-04-07 15:19:47 UTC) #2
Peter Beverloo
Added one and filed an additional issue. Thanks!
3 years, 8 months ago (2017-04-07 15:22:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2805813006/20001
3 years, 8 months ago (2017-04-07 15:44:34 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 17:07:11 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f25963e5ad7ca9e19db5ac255e42...

Powered by Google App Engine
This is Rietveld 408576698