[Home] Add support for snackbars in the BottomSheet

[Home] Add support for snackbars in the BottomSheet

A second SnackbarManager is used to display snackbars on top
of the bottom sheet.

BUG=704128
Review-Url: https://codereview.chromium.org/2806593004
Cr-Commit-Position: refs/heads/master@{#463329}
Committed: https://chromium.googlesource.com/chromium/src/+/f23b1c1dcfe30977bf66bdc90584fe59ab6441ea

[Theresa, 2017-04-07 20:36:37]

The CQ bit was checked by twellington@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-07 20:37:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Theresa, 2017-04-07 20:40:48]

twellington@chromium.org changed reviewers:
+ mdjones@chromium.org

[Theresa, 2017-04-07 20:40:49]

ptal

[commit-bot: I haz the power, 2017-04-07 20:41:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-07 20:41:29]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Theresa, 2017-04-07 20:58:25]

The CQ bit was checked by twellington@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-07 20:59:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 21:09:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-07 21:09:55]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[mdjones, 2017-04-07 22:28:18]

https://codereview.chromium.org/2806593004/diff/20001/chrome/android/java/res...
File chrome/android/java/res/layout/main.xml (right):

https://codereview.chromium.org/2806593004/diff/20001/chrome/android/java/res...
chrome/android/java/res/layout/main.xml:86:
android:layout_marginTop="@dimen/bottom_nav_height_inverse" />
Why not set marginBottom to the positive value?

[Theresa, 2017-04-07 22:34:46]

https://codereview.chromium.org/2806593004/diff/20001/chrome/android/java/res...
File chrome/android/java/res/layout/main.xml (right):

https://codereview.chromium.org/2806593004/diff/20001/chrome/android/java/res...
chrome/android/java/res/layout/main.xml:86:
android:layout_marginTop="@dimen/bottom_nav_height_inverse" />
On 2017/04/07 22:28:18, mdjones wrote:
> Why not set marginBottom to the positive value?

I tried to use marginBottom and it doesn't work. There's another view in this
coordinator layout with a negative top margin, so I expect that custom tabs
folks ran into the same issue.

[Theresa, 2017-04-07 22:35:39]

The CQ bit was checked by twellington@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-07 22:36:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mdjones, 2017-04-07 22:51:24]

lgtm

[Theresa, 2017-04-07 23:02:34]

twellington@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[Theresa, 2017-04-07 23:02:35]

+dfalcantara@ ptal

[gone, 2017-04-07 23:14:56]

lgtm

https://codereview.chromium.org/2806593004/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheetContentController.java
(right):

https://codereview.chromium.org/2806593004/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheetContentController.java:113:
* @param activity
nit: fill this in

[commit-bot: I haz the power, 2017-04-07 23:17:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-07 23:17:04]

Dry run: This issue passed the CQ dry run.

[Theresa, 2017-04-10 16:06:40]

https://codereview.chromium.org/2806593004/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheetContentController.java
(right):

https://codereview.chromium.org/2806593004/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheetContentController.java:113:
* @param activity
On 2017/04/07 23:14:56, dfalcantara (load balance plz) wrote:
> nit: fill this in

Done.

[Theresa, 2017-04-10 16:06:44]

The CQ bit was checked by twellington@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-10 16:07:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 16:49:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-10 16:49:02]

Dry run: This issue passed the CQ dry run.

[Theresa, 2017-04-10 18:08:08]

The CQ bit was checked by twellington@chromium.org

[Theresa, 2017-04-10 18:08:09]

The patchset sent to the CQ was uploaded after l-g-t-m from
mdjones@chromium.org, dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/2806593004/#ps60001
(title: "Fix JavaDoc")

[commit-bot: I haz the power, 2017-04-10 18:09:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 18:16:35]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1491847688805180,
"parent_rev": "a92e7bd9d7d0c02f5350179b0fecbdef0e14b1ff", "commit_rev":
"f23b1c1dcfe30977bf66bdc90584fe59ab6441ea"}

[commit-bot: I haz the power, 2017-04-10 18:17:23]

Description was changed from

==========
[Home] Add support for snackbars in the BottomSheet

A second SnackbarManager is used to display snackbars on top
of the bottom sheet.

BUG=704128
==========

to

==========
[Home] Add support for snackbars in the BottomSheet

A second SnackbarManager is used to display snackbars on top
of the bottom sheet.

BUG=704128

Review-Url: https://codereview.chromium.org/2806593004
Cr-Commit-Position: refs/heads/master@{#463329}
Committed:
https://chromium.googlesource.com/chromium/src/+/f23b1c1dcfe30977bf66bdc90584...
==========

[commit-bot: I haz the power, 2017-04-10 18:17:25]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/f23b1c1dcfe30977bf66bdc90584...