Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(762)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/history/HistoryManager.java

Issue 2806593004: [Home] Add support for snackbars in the BottomSheet (Closed)
Patch Set: Fix JavaDoc Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/history/HistoryManager.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/history/HistoryManager.java b/chrome/android/java/src/org/chromium/chrome/browser/history/HistoryManager.java
index ff156126c6f53e34afd624a8fa44b992d2735bf9..98703724b0faaca8c1b09514668b1dfe03bf1842 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/history/HistoryManager.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/history/HistoryManager.java
@@ -37,8 +37,8 @@ import org.chromium.chrome.browser.profiles.Profile;
import org.chromium.chrome.browser.signin.SigninManager;
import org.chromium.chrome.browser.signin.SigninManager.SignInStateObserver;
import org.chromium.chrome.browser.snackbar.Snackbar;
+import org.chromium.chrome.browser.snackbar.SnackbarManager;
import org.chromium.chrome.browser.snackbar.SnackbarManager.SnackbarController;
-import org.chromium.chrome.browser.snackbar.SnackbarManager.SnackbarManageable;
import org.chromium.chrome.browser.util.IntentUtils;
import org.chromium.chrome.browser.widget.selection.SelectableListLayout;
import org.chromium.chrome.browser.widget.selection.SelectableListToolbar.SearchDelegate;
@@ -71,6 +71,7 @@ public class HistoryManager implements OnMenuItemClickListener, SignInStateObser
private final HistoryManagerToolbar mToolbar;
private final TextView mEmptyView;
private final RecyclerView mRecyclerView;
+ private final SnackbarManager mSnackbarManager;
private LargeIconBridge mLargeIconBridge;
private boolean mIsSearching;
@@ -80,11 +81,14 @@ public class HistoryManager implements OnMenuItemClickListener, SignInStateObser
* @param activity The Activity associated with the HistoryManager.
* @param isSeparateActivity Whether the history UI will be shown in a separate activity than
* the main Chrome activity.
+ * @param snackbarManager The {@link SnackbarManager} used to display snackbars.
*/
@SuppressWarnings("unchecked") // mSelectableListLayout
- public HistoryManager(Activity activity, boolean isSeparateActivity) {
+ public HistoryManager(
+ Activity activity, boolean isSeparateActivity, SnackbarManager snackbarManager) {
mActivity = activity;
mIsSeparateActivity = isSeparateActivity;
+ mSnackbarManager = snackbarManager;
mSelectionDelegate = new SelectionDelegate<>();
mSelectionDelegate.addObserver(this);
@@ -186,7 +190,7 @@ public class HistoryManager implements OnMenuItemClickListener, SignInStateObser
mSelectionDelegate.clearSelection();
Snackbar snackbar = Snackbar.make(mActivity.getString(R.string.copied), this,
Snackbar.TYPE_NOTIFICATION, Snackbar.UMA_HISTORY_LINK_COPIED);
- ((SnackbarManageable) mActivity).getSnackbarManager().showSnackbar(snackbar);
+ mSnackbarManager.showSnackbar(snackbar);
return true;
} else if (item.getItemId() == R.id.selection_mode_open_in_incognito) {
openItemsInNewTabs(mSelectionDelegate.getSelectedItems(), true);

Powered by Google App Engine
This is Rietveld 408576698