Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(909)

Issue 2806553004: relnote: change QuicCryptoClientStreamBase::CryptoConnect API (Closed)

Created:
3 years, 8 months ago by Zhongyi Shi
Modified:
3 years, 8 months ago
Reviewers:
Ryan Hamilton, xunjieli
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

relnote: change QuicCryptoClientStreamBase::CryptoConnect API to return a boolean so that synchronous error can be detected. chromium: Remove QuicChromiumClientSession::ResumeCryptoConnect as well, which is no longer used. Merge internal change: 152398936 BUG=704949 Review-Url: https://codereview.chromium.org/2806553004 Cr-Commit-Position: refs/heads/master@{#462671} Committed: https://chromium.googlesource.com/chromium/src/+/0756f884163fc4b6db4c61d9a06148bec8a0cc20

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -28 lines) Patch
M net/quic/chromium/quic_chromium_client_session.h View 1 chunk +0 lines, -3 lines 0 comments Download
M net/quic/chromium/quic_chromium_client_session.cc View 2 chunks +1 line, -18 lines 0 comments Download
M net/quic/core/quic_crypto_client_stream.h View 2 chunks +4 lines, -3 lines 0 comments Download
M net/quic/core/quic_crypto_client_stream.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/test_tools/mock_crypto_client_stream.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/test_tools/mock_crypto_client_stream.cc View 3 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
Zhongyi Shi
3 years, 8 months ago (2017-04-06 21:01:05 UTC) #3
Ryan Hamilton
lgtm
3 years, 8 months ago (2017-04-06 21:06:50 UTC) #5
xunjieli
On 2017/04/06 21:01:05, Zhongyi Shi wrote: lgtm
3 years, 8 months ago (2017-04-06 21:07:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2806553004/1
3 years, 8 months ago (2017-04-06 22:45:05 UTC) #12
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 23:17:00 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0756f884163fc4b6db4c61d9a061...

Powered by Google App Engine
This is Rietveld 408576698