Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Unified Diff: net/quic/chromium/quic_chromium_client_session.cc

Issue 2806553004: relnote: change QuicCryptoClientStreamBase::CryptoConnect API (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/chromium/quic_chromium_client_session.h ('k') | net/quic/core/quic_crypto_client_stream.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/chromium/quic_chromium_client_session.cc
diff --git a/net/quic/chromium/quic_chromium_client_session.cc b/net/quic/chromium/quic_chromium_client_session.cc
index 64a3a8f473fcfb09978d0be3c6393dee5b57304c..f58bd05a213a2e794e2b29629d4ccc00ced7a2d2 100644
--- a/net/quic/chromium/quic_chromium_client_session.cc
+++ b/net/quic/chromium/quic_chromium_client_session.cc
@@ -670,11 +670,8 @@ int QuicChromiumClientSession::CryptoConnect(
connect_timing_.connect_start = base::TimeTicks::Now();
RecordHandshakeState(STATE_STARTED);
DCHECK(flow_controller());
- crypto_stream_->CryptoConnect();
- // Check if the connection is still open, issues during CryptoConnect like
- // packet write error could cause the connection to be torn down.
- if (!connection()->connected())
+ if (!crypto_stream_->CryptoConnect())
return ERR_QUIC_HANDSHAKE_FAILED;
if (IsCryptoHandshakeConfirmed()) {
@@ -691,20 +688,6 @@ int QuicChromiumClientSession::CryptoConnect(
return ERR_IO_PENDING;
}
-int QuicChromiumClientSession::ResumeCryptoConnect(
- const CompletionCallback& callback) {
- if (IsCryptoHandshakeConfirmed()) {
- connect_timing_.connect_end = base::TimeTicks::Now();
- return OK;
- }
-
- if (!connection()->connected())
- return ERR_QUIC_HANDSHAKE_FAILED;
-
- callback_ = callback;
- return ERR_IO_PENDING;
-}
-
int QuicChromiumClientSession::GetNumSentClientHellos() const {
return crypto_stream_->num_sent_client_hellos();
}
« no previous file with comments | « net/quic/chromium/quic_chromium_client_session.h ('k') | net/quic/core/quic_crypto_client_stream.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698