Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(622)

Issue 2806553002: Gets events dispatching working in mushrome (Closed)

Created:
3 years, 8 months ago by sky
Modified:
3 years, 8 months ago
Reviewers:
sadrul
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Gets events dispatching working in mushrome Without this pre-target handlers on the Shell aren't used, and further it doesn't seem like dispatch works at all without it. BUG=none TEST=none R=sadrul@chromium.org

Patch Set 1 #

Patch Set 2 : fix and merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -4 lines) Patch
M chrome/browser/ui/ash/ash_init.cc View 1 1 chunk +4 lines, -1 line 0 comments Download
M ui/aura/mus/window_tree_client.h View 2 chunks +6 lines, -1 line 0 comments Download
M ui/aura/mus/window_tree_client.cc View 1 2 chunks +12 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
sky
3 years, 8 months ago (2017-04-06 17:30:37 UTC) #1
sadrul
I looked at the change, but looks like we shouldn't need this. Maybe something in ...
3 years, 8 months ago (2017-04-07 03:36:56 UTC) #10
sky
I thought so to. I'll poke at it some more today. On Thu, Apr 6, ...
3 years, 8 months ago (2017-04-07 14:32:48 UTC) #11
sky
On 2017/04/07 14:32:48, sky wrote: > I thought so to. I'll poke at it some ...
3 years, 8 months ago (2017-04-07 18:00:00 UTC) #12
sky
3 years, 8 months ago (2017-04-07 18:20:54 UTC) #13
Message was sent while issue was closed.
On 2017/04/07 18:00:00, sky wrote:
> On 2017/04/07 14:32:48, sky wrote:
> > I thought so to. I'll poke at it some more today.
> > 
> > On Thu, Apr 6, 2017 at 8:36 PM, <mailto:sadrul@chromium.org> wrote:
> > 
> > > I looked at the change, but looks like we shouldn't need this. Maybe
> > > something
> > > in the event-dispatch mechanism is actually wrong. I am looking at this to
> > > see
> > > if I can figure out what the problem is.
> > >
> > > https://codereview.chromium.org/2806553002/
> > >
> > 
> > -- 
> > You received this message because you are subscribed to the Google Groups
> > "Chromium-reviews" group.
> > To unsubscribe from this group and stop receiving emails from it, send an
> email
> > to mailto:chromium-reviews+unsubscribe@chromium.org.
> 
> This patch is wrong. I'll send the right patch and and closing this one out.

The right fix is here: https://codereview.chromium.org/2807683002/

Powered by Google App Engine
This is Rietveld 408576698