Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 2807683002: Properly mark windows for event dispatch in mushrome and fix frames (Closed)

Created:
3 years, 8 months ago by sky
Modified:
3 years, 8 months ago
Reviewers:
msw
CC:
chromium-reviews, kalyank, sadrul, tfarina
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Properly mark windows for event dispatch in mushrome and fix frames Without this we dispatch events to containers, which does nothing. This also makes it so the right frame is created in mushrome mode. BUG=none TEST=none R=msw@chromium.org Review-Url: https://codereview.chromium.org/2807683002 Cr-Commit-Position: refs/heads/master@{#462995} Committed: https://chromium.googlesource.com/chromium/src/+/01af1ced7632270acaeeb0f4f684eee3ea6cd415

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -46 lines) Patch
M ash/root_window_controller.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/BUILD.gn View 2 chunks +2 lines, -1 line 0 comments Download
A + chrome/browser/ui/views/frame/browser_non_client_frame_view_factory_chromeos.cc View 1 chunk +6 lines, -29 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_non_client_frame_view_factory_views.cc View 2 chunks +1 line, -15 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
sky
3 years, 8 months ago (2017-04-07 18:20:30 UTC) #1
msw
lgtm
3 years, 8 months ago (2017-04-07 19:01:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2807683002/1
3 years, 8 months ago (2017-04-07 19:06:54 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 20:44:40 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/01af1ced7632270acaeeb0f4f684...

Powered by Google App Engine
This is Rietveld 408576698