Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 2806533002: [Web Payments] Show a spinner after unmasking a card. (Closed)

Created:
3 years, 8 months ago by anthonyvd
Modified:
3 years, 8 months ago
Reviewers:
Mathieu
CC:
chromium-reviews, tfarina
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Web Payments] Show a spinner after unmasking a card. BUG=706511 Review-Url: https://codereview.chromium.org/2806533002 Cr-Commit-Position: refs/heads/master@{#462624} Committed: https://chromium.googlesource.com/chromium/src/+/7e49f5ac85d0ac4d401349f39f07987475308e36

Patch Set 1 #

Patch Set 2 : User unique_ptr #

Total comments: 2

Patch Set 3 : Add comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -0 lines) Patch
M chrome/browser/ui/views/payments/cvc_unmask_view_controller.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/payments/payment_request_dialog_view.h View 1 2 3 chunks +11 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/payments/payment_request_dialog_view.cc View 1 4 chunks +50 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
anthonyvd
Hi Math, PTAL!
3 years, 8 months ago (2017-04-06 18:37:03 UTC) #6
Mathieu
lgtm! https://codereview.chromium.org/2806533002/diff/20001/chrome/browser/ui/views/payments/payment_request_dialog_view.h File chrome/browser/ui/views/payments/payment_request_dialog_view.h (right): https://codereview.chromium.org/2806533002/diff/20001/chrome/browser/ui/views/payments/payment_request_dialog_view.h#newcode125 chrome/browser/ui/views/payments/payment_request_dialog_view.h:125: // A full dialog overlay that shows a ...
3 years, 8 months ago (2017-04-06 19:06:23 UTC) #7
anthonyvd
https://codereview.chromium.org/2806533002/diff/20001/chrome/browser/ui/views/payments/payment_request_dialog_view.h File chrome/browser/ui/views/payments/payment_request_dialog_view.h (right): https://codereview.chromium.org/2806533002/diff/20001/chrome/browser/ui/views/payments/payment_request_dialog_view.h#newcode125 chrome/browser/ui/views/payments/payment_request_dialog_view.h:125: // A full dialog overlay that shows a spinner ...
3 years, 8 months ago (2017-04-06 20:15:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2806533002/40001
3 years, 8 months ago (2017-04-06 20:17:04 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 21:21:06 UTC) #14
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/7e49f5ac85d0ac4d401349f39f07...

Powered by Google App Engine
This is Rietveld 408576698