[Web Payments] Show a spinner after unmasking a card.

chrome/browser/ui/views/payments/payment_request_dialog_view.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_VIEWS_PAYMENTS_PAYMENT_REQUEST_DIALOG_VIEW_H_
 #define CHROME_BROWSER_UI_VIEWS_PAYMENTS_PAYMENT_REQUEST_DIALOG_VIEW_H_
 
 #include <map>
 #include <memory>
 
 #include "base/macros.h"
 #include "chrome/browser/ui/views/payments/view_stack.h"
 #include "components/payments/content/payment_request_dialog.h"
 #include "components/payments/content/payment_request_spec.h"
+#include "ui/views/controls/throbber.h"
 #include "ui/views/window/dialog_delegate.h"
 
 namespace payments {
 
 class PaymentRequest;
 class PaymentRequestSheetController;
 
 // Maps views owned by PaymentRequestDialogView::view_stack_ to their
 // controller. PaymentRequestDialogView is responsible for listening for those
 // views being removed from the hierarchy and delete the associated controllers.
@@ skipping 68 matching lines @@
   void ShowCreditCardEditor();
   void ShowShippingAddressEditor();
   void EditorViewUpdated();
 
   void ShowCvcUnmaskPrompt(
       const autofill::CreditCard& credit_card,
       base::WeakPtr<autofill::payments::FullCardRequest::ResultDelegate>
           result_delegate,
       content::WebContents* web_contents) override;
 
+  void ShowProcessingSpinner();
+
   ViewStack* view_stack_for_testing() { return &view_stack_; }
 
  private:
   void ShowInitialPaymentSheet();
+  void SetupSpinnerOverlay();
 
   // views::View
   gfx::Size GetPreferredSize() const override;
   void ViewHierarchyChanged(
       const ViewHierarchyChangedDetails& details) override;
 
   // Non-owned reference to the PaymentRequest that initiated this dialog. Since
   // the PaymentRequest object always outlives this one, the pointer should
   // always be valid even though there is no direct ownership relationship
   // between the two.
   PaymentRequest* request_;
   ControllerMap controller_map_;
   ViewStack view_stack_;
 
+  // A full dialog overlay that shows a spinner and the "processing" label. It's

[Mathieu, 2017/04/06 19:06:23]

nit: We could have this sort of documentation on ShowProcessingSpinner as well.

[anthonyvd, 2017/04/06 20:15:08]

Done.

+  // hidden until ShowProcessingSpinner is called.
+  views::View throbber_overlay_;
+  views::Throbber throbber_;
+
   // May be null.
   ObserverForTest* observer_for_testing_;
 
   // Used when the dialog is being closed to avoid re-entrancy into the
   // controller_map_.
   bool being_closed_;
 
   DISALLOW_COPY_AND_ASSIGN(PaymentRequestDialogView);
 };
 
 }  // namespace payments
 
 #endif  // CHROME_BROWSER_UI_VIEWS_PAYMENTS_PAYMENT_REQUEST_DIALOG_VIEW_H_