Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 2806523002: Move isLegacySupportedJavaScriptLanguage() to MIMETypeRegistry (Closed)

Created:
3 years, 8 months ago by hiroshige
Modified:
3 years, 8 months ago
Reviewers:
kinuko, kouhei (in TOK)
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, kinuko+watch, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move isLegacySupportedJavaScriptLanguage() to MIMETypeRegistry This is preparation for https://codereview.chromium.org/2780463002/ that moves callers of isLegacySupportedJavaScriptLanguage() to outside ScriptLoader. BUG=594639, 686281 Review-Url: https://codereview.chromium.org/2806523002 Cr-Commit-Position: refs/heads/master@{#462792} Committed: https://chromium.googlesource.com/chromium/src/+/38295e6a25c1394264de81fedcde29659d03f632

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -28 lines) Patch
M third_party/WebKit/Source/core/dom/ScriptLoader.cpp View 3 chunks +4 lines, -28 lines 0 comments Download
M third_party/WebKit/Source/platform/network/mime/MIMETypeRegistry.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/network/mime/MIMETypeRegistry.cpp View 1 chunk +26 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (8 generated)
hiroshige
PTAL.
3 years, 8 months ago (2017-04-06 19:10:52 UTC) #6
kouhei (in TOK)
lgtm
3 years, 8 months ago (2017-04-06 22:22:39 UTC) #7
hiroshige
kinuko@, could you take a look as a platform/ OWNER?
3 years, 8 months ago (2017-04-07 00:20:55 UTC) #8
kinuko
lgtm!
3 years, 8 months ago (2017-04-07 00:21:29 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2806523002/1
3 years, 8 months ago (2017-04-07 06:14:05 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 06:19:36 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/38295e6a25c1394264de81fedcde...

Powered by Google App Engine
This is Rietveld 408576698