Introduce blink::Script

Introduce blink::Script

This CL introduces blink::Script and ClassicScript that correspond to
https://html.spec.whatwg.org/#concept-script and
https://html.spec.whatwg.org/#classic-script, respectively.

This CL moves classic-script-only logic in ScriptLoader::DoExecuteScript()
(AccessControlStatus and MIME type check) to ClassicScript.

In the rest of this CL, we replace ScriptSourceCode with Script and
wrap ScriptSourceCode by ClassicScript where needed.

Although this CL makes ScriptLoader to handle blink::Script, currently
module scripts are not actually processed because all the call sites supply
ClassicScript, and thus this CL shouldn't change the behavior.

BUG=594639, 686281
Review-Url: https://codereview.chromium.org/2780463002
Cr-Commit-Position: refs/heads/master@{#464161}
Committed: https://chromium.googlesource.com/chromium/src/+/7bd81a2cc4caff15e2d290591b2567a599fbe846

[hiroshige, 2017-03-27 09:37:48]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-27 09:38:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hiroshige, 2017-03-27 09:38:14]

Description was changed from

==========
Introduce blink::Script

BUG=
==========

to

==========
Introduce blink::Script

BUG=
==========

[hiroshige, 2017-03-27 09:38:37]

Description was changed from

==========
Introduce blink::Script

BUG=
==========

to

==========
Introduce blink::Script

ScriptLoader_2_Script

BUG=
==========

[hiroshige, 2017-04-05 21:18:22]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-05 21:19:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hiroshige, 2017-04-05 21:35:03]

Description was changed from

==========
Introduce blink::Script

ScriptLoader_2_Script

BUG=
==========

to

==========
Introduce blink::Script

This CL introduces blink::Script and ClassicScript that correspond to
https://html.spec.whatwg.org/#concept-script and
https://html.spec.whatwg.org/#classic-script, respectively.

In preparation to support module scripts in ScriptController, this CL
makes ScriptController::executeScriptAndReturnValue() and its callers
to receive Script* instead of ScriptSourceCode, and moves the logic of
executeScriptAndReturnValue() to ClassicScript::runScript().

In the rest of this CL, we replace ScriptSourceCode with Script and
wrap ScriptSourceCode by ClassicScript where needed.

BUG=
==========

[hiroshige, 2017-04-05 21:41:23]

Description was changed from

==========
Introduce blink::Script

This CL introduces blink::Script and ClassicScript that correspond to
https://html.spec.whatwg.org/#concept-script and
https://html.spec.whatwg.org/#classic-script, respectively.

In preparation to support module scripts in ScriptController, this CL
makes ScriptController::executeScriptAndReturnValue() and its callers
to receive Script* instead of ScriptSourceCode, and moves the logic of
executeScriptAndReturnValue() to ClassicScript::runScript().

In the rest of this CL, we replace ScriptSourceCode with Script and
wrap ScriptSourceCode by ClassicScript where needed.

BUG=
==========

to

==========
Introduce blink::Script

This CL introduces blink::Script and ClassicScript that correspond to
https://html.spec.whatwg.org/#concept-script and
https://html.spec.whatwg.org/#classic-script, respectively.

In preparation to support module scripts in ScriptController, this CL
makes ScriptController::executeScriptAndReturnValue() and its callers
to receive Script* instead of ScriptSourceCode, and moves the logic of
executeScriptAndReturnValue() to ClassicScript::runScript().

In ScriptLoader::doExecuteScript(), this CL makes MIME type checks and
AccessControlStatus calculation only for classic scripts, because they are
done in different places for module scripts.

In the rest of this CL, we replace ScriptSourceCode with Script and
wrap ScriptSourceCode by ClassicScript where needed.

Although this CL makes ScriptController and ScriptLoader to handle
blink::Script, currently module scripts are not actually processed by them
because all callsites supply ClassicScript, and thus this CL shouldn't
change the behavior.

BUG=
==========

[hiroshige, 2017-04-05 21:41:23]

hiroshige@chromium.org changed reviewers:
+ kouhei@chromium.org

[hiroshige, 2017-04-05 21:41:31]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-05 21:42:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hiroshige, 2017-04-05 23:03:45]

Description was changed from

==========
Introduce blink::Script

This CL introduces blink::Script and ClassicScript that correspond to
https://html.spec.whatwg.org/#concept-script and
https://html.spec.whatwg.org/#classic-script, respectively.

In preparation to support module scripts in ScriptController, this CL
makes ScriptController::executeScriptAndReturnValue() and its callers
to receive Script* instead of ScriptSourceCode, and moves the logic of
executeScriptAndReturnValue() to ClassicScript::runScript().

In ScriptLoader::doExecuteScript(), this CL makes MIME type checks and
AccessControlStatus calculation only for classic scripts, because they are
done in different places for module scripts.

In the rest of this CL, we replace ScriptSourceCode with Script and
wrap ScriptSourceCode by ClassicScript where needed.

Although this CL makes ScriptController and ScriptLoader to handle
blink::Script, currently module scripts are not actually processed by them
because all callsites supply ClassicScript, and thus this CL shouldn't
change the behavior.

BUG=
==========

to

==========
Introduce blink::Script

This CL introduces blink::Script and ClassicScript that correspond to
https://html.spec.whatwg.org/#concept-script and
https://html.spec.whatwg.org/#classic-script, respectively.

In preparation to support module scripts in ScriptController, this CL
makes ScriptController::executeScriptAndReturnValue() and its callers
to receive Script* instead of ScriptSourceCode, and moves the logic of
executeScriptAndReturnValue() to ClassicScript::runScript().

In ScriptLoader::doExecuteScript(), this CL makes MIME type checks and
AccessControlStatus calculation only for classic scripts, because they are
done in different places for module scripts.

In the rest of this CL, we replace ScriptSourceCode with Script and
wrap ScriptSourceCode by ClassicScript where needed.

Although this CL makes ScriptController and ScriptLoader to handle
blink::Script, currently module scripts are not actually processed by them
because all callsites supply ClassicScript, and thus this CL shouldn't
change the behavior.

BUG=594639, 686281
==========

[hiroshige, 2017-04-05 23:09:05]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-05 23:09:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hiroshige, 2017-04-05 23:12:32]

hiroshige@chromium.org changed reviewers:
+ sigbjornf@opera.com

[hiroshige, 2017-04-05 23:12:33]

PTAL.

I'm not so sure about the places of classes, especially
ClassicScript (bindings/core/v8 i.e. the same directory as ScriptSourceCode or
core/dom i.e. the same as ModuleScript? currently I put ClassicScript to
ScriptSourceCode.h but I'll move it to a new file once the directory is
determined) and
Script::runScript() (it touches v8 things).
WDYT?

[hiroshige, 2017-04-06 00:34:55]

On 2017/04/05 23:12:33, hiroshige wrote:
> PTAL.
> 
> I'm not so sure about the places of classes, especially
> ClassicScript (bindings/core/v8 i.e. the same directory as ScriptSourceCode or
> core/dom i.e. the same as ModuleScript? currently I put ClassicScript to
> ScriptSourceCode.h but I'll move it to a new file once the directory is
> determined) and
> Script::runScript() (it touches v8 things).
> WDYT?

Discussed briefly with kouhei@ and I'll try to decouple bindings/ and core/.

[commit-bot: I haz the power, 2017-04-06 01:02:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-06 01:02:08]

Dry run: This issue passed the CQ dry run.

[hiroshige, 2017-04-06 01:53:07]

Patchset #9 (id:160001) has been deleted

[hiroshige, 2017-04-06 01:58:59]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-06 01:59:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hiroshige, 2017-04-06 02:04:42]

I changed the code structure so that the execution goes core->bindings
(ScriptLoader::doExecuteScript() -> Script::runScript() -> bindings/ including
ScriptController).
ScriptController will remain classic-script-only, and ModuleScript::runScript()
will be implemented using ScriptModule (via Modulator in kouhei's side), without
ScriptController.

Also I moved more classic-script-only logic from ScriptLoader to ClassicScript.

[hiroshige, 2017-04-06 02:04:48]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-06 02:05:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hiroshige, 2017-04-06 02:55:07]

hiroshige@chromium.org changed reviewers:
+ japhet@chromium.org

[hiroshige, 2017-04-06 02:55:08]

+japhet@.

[commit-bot: I haz the power, 2017-04-06 05:33:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-06 05:33:33]

Dry run: This issue passed the CQ dry run.

[kouhei (in TOK), 2017-04-06 09:42:35]

Wow. I think this makes a lot of sense. Please update desc.

https://codereview.chromium.org/2780463002/diff/200001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/dom/ModuleScript.h (right):

https://codereview.chromium.org/2780463002/diff/200001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/dom/ModuleScript.h:30: class CORE_EXPORT
ModuleScript final : public Script, public TraceWrapperBase {
I think Script needs to be TraceWrapperBase if we allow Member<Script>

https://codereview.chromium.org/2780463002/diff/200001/third_party/WebKit/Sou...
File third_party/WebKit/Source/platform/network/mime/MIMETypeRegistry.h (right):

https://codereview.chromium.org/2780463002/diff/200001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/network/mime/MIMETypeRegistry.h:72: static
bool isLegacySupportedJavaScriptLanguage(const String& language);
Please split CL or document this change in desc

[hiroshige, 2017-04-06 17:27:32]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-06 17:28:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hiroshige, 2017-04-06 17:36:18]

Description was changed from

==========
Introduce blink::Script

This CL introduces blink::Script and ClassicScript that correspond to
https://html.spec.whatwg.org/#concept-script and
https://html.spec.whatwg.org/#classic-script, respectively.

In preparation to support module scripts in ScriptController, this CL
makes ScriptController::executeScriptAndReturnValue() and its callers
to receive Script* instead of ScriptSourceCode, and moves the logic of
executeScriptAndReturnValue() to ClassicScript::runScript().

In ScriptLoader::doExecuteScript(), this CL makes MIME type checks and
AccessControlStatus calculation only for classic scripts, because they are
done in different places for module scripts.

In the rest of this CL, we replace ScriptSourceCode with Script and
wrap ScriptSourceCode by ClassicScript where needed.

Although this CL makes ScriptController and ScriptLoader to handle
blink::Script, currently module scripts are not actually processed by them
because all callsites supply ClassicScript, and thus this CL shouldn't
change the behavior.

BUG=594639, 686281
==========

to

==========
Introduce blink::Script

This CL introduces blink::Script and ClassicScript that correspond to
https://html.spec.whatwg.org/#concept-script and
https://html.spec.whatwg.org/#classic-script, respectively.

This CL moves classic-script-only logic in ScriptLoader::doExecuteScript()
(AccessControlStatus and MIME type check) to ClassicScript.

In the rest of this CL, we replace ScriptSourceCode with Script and
wrap ScriptSourceCode by ClassicScript where needed.

Although this CL makes ScriptLoader to handle blink::Script, currently
module scripts are not actually processed because all the call sites supply
ClassicScript, and thus this CL shouldn't change the behavior.

BUG=594639, 686281
==========

[hiroshige, 2017-04-06 17:36:30]

https://codereview.chromium.org/2780463002/diff/200001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/dom/ModuleScript.h (right):

https://codereview.chromium.org/2780463002/diff/200001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/dom/ModuleScript.h:30: class CORE_EXPORT
ModuleScript final : public Script, public TraceWrapperBase {
On 2017/04/06 09:42:35, kouhei wrote:
> I think Script needs to be TraceWrapperBase if we allow Member<Script>

Done.

https://codereview.chromium.org/2780463002/diff/200001/third_party/WebKit/Sou...
File third_party/WebKit/Source/platform/network/mime/MIMETypeRegistry.h (right):

https://codereview.chromium.org/2780463002/diff/200001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/network/mime/MIMETypeRegistry.h:72: static
bool isLegacySupportedJavaScriptLanguage(const String& language);
On 2017/04/06 09:42:35, kouhei wrote:
> Please split CL or document this change in desc

Split as https://codereview.chromium.org/2806523002.

[hiroshige, 2017-04-06 17:37:09]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-06 17:37:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 18:59:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-06 18:59:33]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[kouhei (in TOK), 2017-04-06 22:33:53]

lgtm

[hiroshige, 2017-04-07 17:57:42]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-07 17:58:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 19:37:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-07 19:37:29]

Dry run: This issue passed the CQ dry run.

[hiroshige, 2017-04-07 23:21:14]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-07 23:22:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-08 01:34:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-08 01:34:03]

Dry run: This issue passed the CQ dry run.

[hiroshige, 2017-04-10 20:48:24]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-10 20:48:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hiroshige, 2017-04-10 20:55:23]

Description was changed from

==========
Introduce blink::Script

This CL introduces blink::Script and ClassicScript that correspond to
https://html.spec.whatwg.org/#concept-script and
https://html.spec.whatwg.org/#classic-script, respectively.

This CL moves classic-script-only logic in ScriptLoader::doExecuteScript()
(AccessControlStatus and MIME type check) to ClassicScript.

In the rest of this CL, we replace ScriptSourceCode with Script and
wrap ScriptSourceCode by ClassicScript where needed.

Although this CL makes ScriptLoader to handle blink::Script, currently
module scripts are not actually processed because all the call sites supply
ClassicScript, and thus this CL shouldn't change the behavior.

BUG=594639, 686281
==========

to

==========
Introduce blink::Script

This CL introduces blink::Script and ClassicScript that correspond to
https://html.spec.whatwg.org/#concept-script and
https://html.spec.whatwg.org/#classic-script, respectively.

This CL moves classic-script-only logic in ScriptLoader::DoExecuteScript()
(AccessControlStatus and MIME type check) to ClassicScript.

In the rest of this CL, we replace ScriptSourceCode with Script and
wrap ScriptSourceCode by ClassicScript where needed.

Although this CL makes ScriptLoader to handle blink::Script, currently
module scripts are not actually processed because all the call sites supply
ClassicScript, and thus this CL shouldn't change the behavior.

BUG=594639, 686281
==========

[hiroshige, 2017-04-10 21:30:27]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-10 21:31:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hiroshige, 2017-04-10 22:24:09]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-10 22:24:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hiroshige, 2017-04-10 22:36:03]

Rebased after renaming. Could you take a look?

Also, this CL introduces class Script, while Blink has Script() methods (at
least 5 classes has Script() member function). Should we rename them to
GetScript() first?

[Nate Chapin, 2017-04-10 23:48:15]

LGTM. Agreed that it might be wise to rename Script->GetScript() first.

[hiroshige, 2017-04-11 00:54:56]

On 2017/04/10 23:48:15, Nate Chapin wrote:
> LGTM. Agreed that it might be wise to rename Script->GetScript() first.

Created CLs renaming Script() to other names.

[commit-bot: I haz the power, 2017-04-11 01:34:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-11 01:34:41]

Dry run: This issue passed the CQ dry run.

[hiroshige, 2017-04-12 17:26:27]

The CQ bit was checked by hiroshige@chromium.org

[hiroshige, 2017-04-12 17:26:28]

The patchset sent to the CQ was uploaded after l-g-t-m from kouhei@chromium.org
Link to the patchset: https://codereview.chromium.org/2780463002/#ps340001
(title: "fix ScriptSourceCode() bug")

[commit-bot: I haz the power, 2017-04-12 17:27:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 17:30:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 17:30:35]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[hiroshige, 2017-04-12 17:55:00]

The CQ bit was checked by hiroshige@chromium.org

[hiroshige, 2017-04-12 17:55:01]

The patchset sent to the CQ was uploaded after l-g-t-m from japhet@chromium.org,
kouhei@chromium.org
Link to the patchset: https://codereview.chromium.org/2780463002/#ps360001
(title: "Rebase")

[commit-bot: I haz the power, 2017-04-12 17:56:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 20:26:13]

CQ is committing da patch.

Bot data: {"patchset_id": 360001, "attempt_start_ts": 1492019700770420,
"parent_rev": "9acab5dd4495ba6eae78c05659ea09bb601405df", "commit_rev":
"7ec1e1bc76b8e9278fb9d8e533f6e59bca08d441"}

[commit-bot: I haz the power, 2017-04-12 21:08:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 21:08:53]

Prior attempt to commit was detected, but we were not able to check whether the
issue was successfully committed. Please check Git history manually and re-check
CQ or close this issue as needed.

[hiroshige, 2017-04-12 21:23:56]

The CQ bit was checked by hiroshige@chromium.org

[commit-bot: I haz the power, 2017-04-12 21:24:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 21:49:15]

CQ is committing da patch.

Bot data: {"patchset_id": 360001, "attempt_start_ts": 1492032236625360,
"parent_rev": "ae8e1bba3b31aa540ad7684e75374d193946d4e2", "commit_rev":
"7bd81a2cc4caff15e2d290591b2567a599fbe846"}

[commit-bot: I haz the power, 2017-04-12 21:50:11]

Description was changed from

==========
Introduce blink::Script

This CL introduces blink::Script and ClassicScript that correspond to
https://html.spec.whatwg.org/#concept-script and
https://html.spec.whatwg.org/#classic-script, respectively.

This CL moves classic-script-only logic in ScriptLoader::DoExecuteScript()
(AccessControlStatus and MIME type check) to ClassicScript.

In the rest of this CL, we replace ScriptSourceCode with Script and
wrap ScriptSourceCode by ClassicScript where needed.

Although this CL makes ScriptLoader to handle blink::Script, currently
module scripts are not actually processed because all the call sites supply
ClassicScript, and thus this CL shouldn't change the behavior.

BUG=594639, 686281
==========

to

==========
Introduce blink::Script

This CL introduces blink::Script and ClassicScript that correspond to
https://html.spec.whatwg.org/#concept-script and
https://html.spec.whatwg.org/#classic-script, respectively.

This CL moves classic-script-only logic in ScriptLoader::DoExecuteScript()
(AccessControlStatus and MIME type check) to ClassicScript.

In the rest of this CL, we replace ScriptSourceCode with Script and
wrap ScriptSourceCode by ClassicScript where needed.

Although this CL makes ScriptLoader to handle blink::Script, currently
module scripts are not actually processed because all the call sites supply
ClassicScript, and thus this CL shouldn't change the behavior.

BUG=594639, 686281

Review-Url: https://codereview.chromium.org/2780463002
Cr-Commit-Position: refs/heads/master@{#464161}
Committed:
https://chromium.googlesource.com/chromium/src/+/7bd81a2cc4caff15e2d290591b25...
==========

[commit-bot: I haz the power, 2017-04-12 21:50:14]

Committed patchset #18 (id:360001) as
https://chromium.googlesource.com/chromium/src/+/7bd81a2cc4caff15e2d290591b25...