Show keyboard on URL bar whenever it regains window focus

Show keyboard on URL bar whenever it regains window focus

Currently, we show keyboard on window focus gain only when we previously
lost window visibility, which we introduced to fix crbug.com/168288.

Extending the current logic to resume keyboard input when regaining
focus from a pop-up window such as voice input window.

BUG=344235
Review-Url: https://codereview.chromium.org/2806383003
Cr-Commit-Position: refs/heads/master@{#463405}
Committed: https://chromium.googlesource.com/chromium/src/+/5b67e8ee116312b0fe17172105c8575cbbf45e66

[Changwan Ryu, 2017-04-10 17:28:10]

The CQ bit was checked by changwan@chromium.org to run a CQ dry run

[Changwan Ryu, 2017-04-10 17:28:21]

changwan@chromium.org changed reviewers:
+ tedchoc@chromium.org

[commit-bot: I haz the power, 2017-04-10 17:28:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 18:05:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-10 18:05:44]

Dry run: This issue passed the CQ dry run.

[Ted C, 2017-04-10 18:27:13]

https://codereview.chromium.org/2806383003/diff/1/chrome/android/java/src/org...
File chrome/android/java/src/org/chromium/chrome/browser/omnibox/UrlBar.java
(left):

https://codereview.chromium.org/2806383003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/omnibox/UrlBar.java:525: if
(mShowKeyboardOnWindowFocus && isFocused()) {
Does this do anything wonky with multi-window where you can switch between
windows?  I guess the worst that happens would be that it brings up the keyboard
if you had dismissed it via the back button when you switch to a window and
back.

I wonder if we should somehow capture the case where the user dismissed the
keyboard manually and did not do it in that case.  I don't know if that is
really all that feasible though.

[Ted C, 2017-04-10 21:02:00]

lgtm

[Changwan Ryu, 2017-04-10 21:17:06]

https://codereview.chromium.org/2806383003/diff/1/chrome/android/java/src/org...
File chrome/android/java/src/org/chromium/chrome/browser/omnibox/UrlBar.java
(left):

https://codereview.chromium.org/2806383003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/omnibox/UrlBar.java:525: if
(mShowKeyboardOnWindowFocus && isFocused()) {
On 2017/04/10 18:27:13, Ted C wrote:
> Does this do anything wonky with multi-window where you can switch between
> windows?  I guess the worst that happens would be that it brings up the
keyboard
> if you had dismissed it via the back button when you switch to a window and
> back.
> 
> I wonder if we should somehow capture the case where the user dismissed the
> keyboard manually and did not do it in that case.  I don't know if that is
> really all that feasible though.

For the record, here's the summary of what we talked offline:

I couldn't think of any problem with split-window scenarios. If keyboard was
showing up for another app in the top window, Chrome app in the bottom window
will be partially hidden, and you have no choice but to touch the URL bar to
bring Chrome forward, it wobbles a bit, but it is the case without this logic
because you either give URL bar view focus or touching URL bar shows keyboard
anyways..

Unfortunately, there is no legitimate way of keeping track of manually dismissed
window.

[Changwan Ryu, 2017-04-10 21:17:11]

The CQ bit was checked by changwan@chromium.org

[commit-bot: I haz the power, 2017-04-10 21:17:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 21:40:36]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1491859031817770, "parent_rev":
"514a2755c94d9333fb54925d3ca7a818cd40189e", "commit_rev":
"5b67e8ee116312b0fe17172105c8575cbbf45e66"}

[commit-bot: I haz the power, 2017-04-10 21:41:31]

Description was changed from

==========
Show keyboard on URL bar whenever it regains window focus

Currently, we show keyboard on window focus gain only when we previously
lost window visibility, which we introduced to fix crbug.com/168288.

Extending the current logic to resume keyboard input when regaining
focus from a pop-up window such as voice input window.

BUG=344235
==========

to

==========
Show keyboard on URL bar whenever it regains window focus

Currently, we show keyboard on window focus gain only when we previously
lost window visibility, which we introduced to fix crbug.com/168288.

Extending the current logic to resume keyboard input when regaining
focus from a pop-up window such as voice input window.

BUG=344235

Review-Url: https://codereview.chromium.org/2806383003
Cr-Commit-Position: refs/heads/master@{#463405}
Committed:
https://chromium.googlesource.com/chromium/src/+/5b67e8ee116312b0fe17172105c8...
==========

[commit-bot: I haz the power, 2017-04-10 21:41:32]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5b67e8ee116312b0fe17172105c8...