Show keyboard on URL bar whenever it regains window focus

chrome/android/java/src/org/chromium/chrome/browser/omnibox/UrlBar.java

Index: chrome/android/java/src/org/chromium/chrome/browser/omnibox/UrlBar.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/omnibox/UrlBar.java b/chrome/android/java/src/org/chromium/chrome/browser/omnibox/UrlBar.java
index 8fa4ae6e01ed01a951947514061cacaa646a9df3..9dc8a9860b4073bb498982825d4de174ba3cdef4 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/omnibox/UrlBar.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/omnibox/UrlBar.java
@@ -71,8 +71,6 @@ public class UrlBar extends VerticallyFixedEditText {
     /** The contents of the URL that precede the path/query before formatting. */
     private String mOriginalUrlLocation;
 
-    private boolean mShowKeyboardOnWindowFocus;
-
     private boolean mFirstDrawComplete;
 
     /**
@@ -513,16 +511,11 @@ public class UrlBar extends VerticallyFixedEditText {
     }
 
     @Override
-    protected void onWindowVisibilityChanged(int visibility) {
-        super.onWindowVisibilityChanged(visibility);
-        if (visibility == View.GONE && isFocused()) mShowKeyboardOnWindowFocus = true;
-    }
-
-    @Override
     public void onWindowFocusChanged(boolean hasWindowFocus) {
         super.onWindowFocusChanged(hasWindowFocus);
+        if (DEBUG) Log.i(TAG, "onWindowFocusChanged: " + hasWindowFocus);
         if (hasWindowFocus) {
-            if (mShowKeyboardOnWindowFocus && isFocused()) {

[Ted C, 2017/04/10 18:27:13]

Does this do anything wonky with multi-window where you can switch between
windows?  I guess the worst that happens would be that it brings up the keyboard
if you had dismissed it via the back button when you switch to a window and
back.

I wonder if we should somehow capture the case where the user dismissed the
keyboard manually and did not do it in that case.  I don't know if that is
really all that feasible though.

[Changwan Ryu, 2017/04/10 21:17:06]

For the record, here's the summary of what we talked offline:

I couldn't think of any problem with split-window scenarios. If keyboard was
showing up for another app in the top window, Chrome app in the bottom window
will be partially hidden, and you have no choice but to touch the URL bar to
bring Chrome forward, it wobbles a bit, but it is the case without this logic
because you either give URL bar view focus or touching URL bar shows keyboard
anyways..

Unfortunately, there is no legitimate way of keeping track of manually dismissed
window.

+            if (isFocused()) {
                 // Without the call to post(..), the keyboard was not getting shown when the
                 // window regained focus despite this being the final call in the view system
                 // flow.
@@ -533,7 +526,6 @@ public class UrlBar extends VerticallyFixedEditText {
                     }
                 });
             }
-            mShowKeyboardOnWindowFocus = false;
         }
     }