[v8] v8::StackTrace::AsArray returns correct array

[v8] v8::StackTrace::AsArray returns correct array

After [1] we return JSArray with internal structs, we should return JSObjects instead.

[1] https://codereview.chromium.org/2789073002

BUG=v8:6189
R=yangguo@chromium.org

Review-Url: https://codereview.chromium.org/2806373005
Cr-Commit-Position: refs/heads/master@{#44581}
Committed: https://chromium.googlesource.com/v8/v8/+/2e4a68733803222274b1e029081ecd650b4344d6

[kozy, 2017-04-10 21:44:43]

Yang, please take a look.

It looks like neither chromium nor node.js use this API and maybe we can just
remove it.

[kozy, 2017-04-10 21:44:49]

The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-10 21:44:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kozy, 2017-04-10 21:47:31]

Description was changed from

==========
[v8] v8::StackTrace::AsArray returns correct array

BUG=v8:6189
R=yangguo@chromium.org
==========

to

==========
[v8] v8::StackTrace::AsArray returns correct array

After [1] we return JSArray with internal structs, we should return JSObjects
instead.

[1] https://codereview.chromium.org/2789073002

BUG=v8:6189
R=yangguo@chromium.org
==========

[kozy, 2017-04-10 21:56:18]

The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-10 21:56:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 22:55:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-10 22:55:45]

Dry run: This issue passed the CQ dry run.

[Yang, 2017-04-11 13:05:49]

LGTM with comment addressed.

https://codereview.chromium.org/2806373005/diff/20001/src/api.cc
File src/api.cc (right):

https://codereview.chromium.org/2806373005/diff/20001/src/api.cc#newcode2919
src/api.cc:2919: Local<Array> StackTrace::AsArray() {
AsArray doesnt seem to be used anywhere in Chromium nor Node.js. Can we simply
assume options to be kDetailed (i.e. add property for everything), and also mark
AsArray as deprecated, so that we can remove it at some point?

[kozy, 2017-04-11 15:04:06]

all done.

https://codereview.chromium.org/2806373005/diff/20001/src/api.cc
File src/api.cc (right):

https://codereview.chromium.org/2806373005/diff/20001/src/api.cc#newcode2919
src/api.cc:2919: Local<Array> StackTrace::AsArray() {
On 2017/04/11 13:05:49, Yang wrote:
> AsArray doesnt seem to be used anywhere in Chromium nor Node.js. Can we simply
> assume options to be kDetailed (i.e. add property for everything), and also
mark
> AsArray as deprecated, so that we can remove it at some point?

Done.

[kozy, 2017-04-11 15:04:10]

The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-11 15:04:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kozy, 2017-04-11 15:05:14]

I'll land it so it looks like important fix of C++ V8 API.

[kozy, 2017-04-11 15:05:20]

The CQ bit was unchecked by kozyatinskiy@chromium.org

[kozy, 2017-04-11 15:05:23]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2017-04-11 15:05:23]

The patchset sent to the CQ was uploaded after l-g-t-m from yangguo@chromium.org
Link to the patchset: https://codereview.chromium.org/2806373005/#ps40001
(title: "addressed comments")

[commit-bot: I haz the power, 2017-04-11 15:05:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yang, 2017-04-11 15:24:00]

lgtm. thanks

[commit-bot: I haz the power, 2017-04-11 15:30:50]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1491923123533640,
"parent_rev": "fdcc57bd844c3f14e77e28cff94c6fbbbd18c21e", "commit_rev":
"2e4a68733803222274b1e029081ecd650b4344d6"}

[commit-bot: I haz the power, 2017-04-11 15:30:58]

Description was changed from

==========
[v8] v8::StackTrace::AsArray returns correct array

After [1] we return JSArray with internal structs, we should return JSObjects
instead.

[1] https://codereview.chromium.org/2789073002

BUG=v8:6189
R=yangguo@chromium.org
==========

to

==========
[v8] v8::StackTrace::AsArray returns correct array

After [1] we return JSArray with internal structs, we should return JSObjects
instead.

[1] https://codereview.chromium.org/2789073002

BUG=v8:6189
R=yangguo@chromium.org

Review-Url: https://codereview.chromium.org/2806373005
Cr-Commit-Position: refs/heads/master@{#44581}
Committed:
https://chromium.googlesource.com/v8/v8/+/2e4a68733803222274b1e029081ecd650b4...
==========

[commit-bot: I haz the power, 2017-04-11 15:30:59]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/2e4a68733803222274b1e029081ecd650b4...