Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: include/v8.h

Issue 2806373005: [v8] v8::StackTrace::AsArray returns correct array (Closed)
Patch Set: addressed comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/v8.h
diff --git a/include/v8.h b/include/v8.h
index ae84f389ab16f426d493fb74d18acc7c715588ca..d1fe2e4741799087c94c8cdc7fd14917f80aa8f9 100644
--- a/include/v8.h
+++ b/include/v8.h
@@ -1542,6 +1542,8 @@ class V8_EXPORT StackTrace {
/**
* Flags that determine what information is placed captured for each
* StackFrame when grabbing the current stack trace.
+ * Note: these options are deprecated and we always collect all available
+ * information (kDetailed).
*/
enum StackTraceOptions {
kLineNumber = 1,
@@ -1570,7 +1572,7 @@ class V8_EXPORT StackTrace {
/**
* Returns StackTrace as a v8::Array that contains StackFrame objects.
*/
- Local<Array> AsArray();
+ V8_DEPRECATED("Use native API instead", Local<Array> AsArray());
/**
* Grab a snapshot of the current JavaScript execution stack.
@@ -1580,9 +1582,7 @@ class V8_EXPORT StackTrace {
* StackFrame.
*/
static Local<StackTrace> CurrentStackTrace(
- Isolate* isolate,
- int frame_limit,
- StackTraceOptions options = kOverview);
+ Isolate* isolate, int frame_limit, StackTraceOptions options = kDetailed);
};
« no previous file with comments | « no previous file | src/api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698