bindings: Call member.includes_for_type() for container types too.

bindings: Call member.includes_for_type() for container types too.

Follow-up to commit 8552274ebe ("bindings: Correctly expand all class/header
dependencies in unions"), which caused member.includes_for_type() not to be
called when a nested union member is processed.

We now call it in all cases, even for container types such as records,
sequences and unions, otherwise we risk skipping includes that come from the
type (e.g. IDLRecord) itself. This does not happen at the moment, but may in
the future, such as when we start converting sequences via IDLSequence and
NativeValueTraits::NativeValue().

BUG=690428
R=bashi@chromium.org,haraken@chromium.org,yukishiino@chromium.org

Review-Url: https://codereview.chromium.org/2806343002
Cr-Commit-Position: refs/heads/master@{#463268}
Committed: https://chromium.googlesource.com/chromium/src/+/0338b35867900b81de5e6960eec0572f152974b7

[Raphael Kubo da Costa (rakuco), 2017-04-10 13:16:05]

PTAL

[Raphael Kubo da Costa (rakuco), 2017-04-10 13:16:09]

The CQ bit was checked by raphael.kubo.da.costa@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-10 13:16:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yuki, 2017-04-10 13:36:41]

LGTM.

[haraken, 2017-04-10 14:09:52]

LGTM

[commit-bot: I haz the power, 2017-04-10 15:14:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-10 15:14:43]

Dry run: This issue passed the CQ dry run.

[Raphael Kubo da Costa (rakuco), 2017-04-10 15:16:05]

The CQ bit was checked by raphael.kubo.da.costa@intel.com

[commit-bot: I haz the power, 2017-04-10 15:16:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 15:29:06]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491837365505070,
"parent_rev": "3ee0d50b813ac1cf8cef5cc703bb1e9d218ffd58", "commit_rev":
"0338b35867900b81de5e6960eec0572f152974b7"}

[commit-bot: I haz the power, 2017-04-10 15:29:55]

Description was changed from

==========
bindings: Call member.includes_for_type() for container types too.

Follow-up to commit 8552274ebe ("bindings: Correctly expand all class/header
dependencies in unions"), which caused member.includes_for_type() not to be
called when a nested union member is processed.

We now call it in all cases, even for container types such as records,
sequences and unions, otherwise we risk skipping includes that come from the
type (e.g. IDLRecord) itself. This does not happen at the moment, but may in
the future, such as when we start converting sequences via IDLSequence and
NativeValueTraits::NativeValue().

BUG=690428
R=bashi@chromium.org,haraken@chromium.org,yukishiino@chromium.org
==========

to

==========
bindings: Call member.includes_for_type() for container types too.

Follow-up to commit 8552274ebe ("bindings: Correctly expand all class/header
dependencies in unions"), which caused member.includes_for_type() not to be
called when a nested union member is processed.

We now call it in all cases, even for container types such as records,
sequences and unions, otherwise we risk skipping includes that come from the
type (e.g. IDLRecord) itself. This does not happen at the moment, but may in
the future, such as when we start converting sequences via IDLSequence and
NativeValueTraits::NativeValue().

BUG=690428
R=bashi@chromium.org,haraken@chromium.org,yukishiino@chromium.org

Review-Url: https://codereview.chromium.org/2806343002
Cr-Commit-Position: refs/heads/master@{#463268}
Committed:
https://chromium.googlesource.com/chromium/src/+/0338b35867900b81de5e6960eec0...
==========

[commit-bot: I haz the power, 2017-04-10 15:29:56]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0338b35867900b81de5e6960eec0...