Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Unified Diff: third_party/WebKit/Source/bindings/scripts/v8_union.py

Issue 2806343002: bindings: Call member.includes_for_type() for container types too. (Closed)
Patch Set: bindings: Call member.includes_for_type() for container types too. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/scripts/v8_union.py
diff --git a/third_party/WebKit/Source/bindings/scripts/v8_union.py b/third_party/WebKit/Source/bindings/scripts/v8_union.py
index da193080c9f36e8a7bad57a7d3c9631b69d80d6d..35477a1abce86ca6eb0439cc847aa3418d54eb07 100644
--- a/third_party/WebKit/Source/bindings/scripts/v8_union.py
+++ b/third_party/WebKit/Source/bindings/scripts/v8_union.py
@@ -140,14 +140,12 @@ def _update_includes_and_forward_decls(member, info_provider):
_update_includes_and_forward_decls(member.value_type, info_provider)
elif member.is_array_or_sequence_type:
_update_includes_and_forward_decls(member.element_type, info_provider)
- else:
- if member.is_union_type:
- # Reaching this block means we have a union that is inside a
- # record or sequence.
- header_forward_decls.add(member.name)
- cpp_includes.update([info_provider.include_path_for_union_types(member)])
- else:
- cpp_includes.update(member.includes_for_type())
+ elif member.is_union_type:
+ # Reaching this block means we have a union that is inside a
+ # record or sequence.
+ header_forward_decls.add(member.name)
+ cpp_includes.update([info_provider.include_path_for_union_types(member)])
+ cpp_includes.update(member.includes_for_type())
def member_context(member, info_provider):
« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/tests/results/core/NodeOrLongSequenceOrEventOrXMLHttpRequestOrStringOrStringByteStringOrNodeListRecord.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698