[debug,api] Do not use embedder field for debug context id.

[debug,api] Do not use embedder field for debug context id.

We used to reserve the 0-th embedder data field for the debug
context id. This is no longer necessary since the inspector
has migrated to be part of V8. This makes the API a bit simpler.

R=clemensh@chromium.org, jochen@chromium.org, kozyatinskiy@chromium.org
BUG=v8:5530
Review-Url: https://codereview.chromium.org/2806303002
Cr-Commit-Position: refs/heads/master@{#44607}
Committed: https://chromium.googlesource.com/v8/v8/+/5f90a6eb0675b79f2bc29ebfa05d30051d3bd23e

[Yang, 2017-04-10 09:31:19]

Please take a look. I will not land this before branch cut.

[jochen (gone - plz use gerrit), 2017-04-10 12:50:34]

maybe keep the constant around? It's not like it hurts anybody

https://codereview.chromium.org/2806303002/diff/1/include/v8.h
File include/v8.h (left):

https://codereview.chromium.org/2806303002/diff/1/include/v8.h#oldcode8305
include/v8.h:8305: enum EmbedderDataFields { kDebugIdIndex = 0 };
this won't work unless you first clean up blink

[Yang, 2017-04-10 12:53:12]

On 2017/04/10 12:50:34, jochen wrote:
> maybe keep the constant around? It's not like it hurts anybody
> 
> https://codereview.chromium.org/2806303002/diff/1/include/v8.h
> File include/v8.h (left):
> 
> https://codereview.chromium.org/2806303002/diff/1/include/v8.h#oldcode8305
> include/v8.h:8305: enum EmbedderDataFields { kDebugIdIndex = 0 };
> this won't work unless you first clean up blink

mkay... restored it. Now I don't need to wait for branch cut anymore, right?

[Yang, 2017-04-10 12:53:17]

The CQ bit was checked by yangguo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-10 12:53:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jochen (gone - plz use gerrit), 2017-04-10 12:57:36]

lgtm for v8.h :)

[commit-bot: I haz the power, 2017-04-10 13:21:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-10 13:21:38]

Dry run: This issue passed the CQ dry run.

[kozy, 2017-04-10 14:32:18]

thanks, lgtm.
It looks like getting debugger context id should be much faster then before?

[Yang, 2017-04-10 14:51:05]

On 2017/04/10 14:32:18, kozy wrote:
> thanks, lgtm.
> It looks like getting debugger context id should be much faster then before?

very slightly, yes.

[Yang, 2017-04-12 05:49:35]

Clemens, ping :)

[Clemens Hammacher, 2017-04-12 07:53:27]

On 2017/04/12 at 05:49:35, yangguo wrote:
> Clemens, ping :)

Thanks! LGTM

[Yang, 2017-04-12 10:58:25]

The CQ bit was checked by yangguo@chromium.org

[commit-bot: I haz the power, 2017-04-12 10:58:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 11:24:45]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491994705674720,
"parent_rev": "f4ba786de8c182db79c293697b81184df41c6344", "commit_rev":
"5f90a6eb0675b79f2bc29ebfa05d30051d3bd23e"}

[commit-bot: I haz the power, 2017-04-12 11:24:51]

Description was changed from

==========
[debug,api] Do not use embedder field for debug context id.

We used to reserve the 0-th embedder data field for the debug
context id. This is no longer necessary since the inspector
has migrated to be part of V8. This makes the API a bit simpler.

R=clemensh@chromium.org, jochen@chromium.org, kozyatinskiy@chromium.org
BUG=v8:5530
==========

to

==========
[debug,api] Do not use embedder field for debug context id.

We used to reserve the 0-th embedder data field for the debug
context id. This is no longer necessary since the inspector
has migrated to be part of V8. This makes the API a bit simpler.

R=clemensh@chromium.org, jochen@chromium.org, kozyatinskiy@chromium.org
BUG=v8:5530

Review-Url: https://codereview.chromium.org/2806303002
Cr-Commit-Position: refs/heads/master@{#44607}
Committed:
https://chromium.googlesource.com/v8/v8/+/5f90a6eb0675b79f2bc29ebfa05d30051d3...
==========

[commit-bot: I haz the power, 2017-04-12 11:24:52]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/5f90a6eb0675b79f2bc29ebfa05d30051d3...