Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Side by Side Diff: src/inspector/inspected-context.cc

Issue 2806303002: [debug,api] Do not use embedder field for debug context id. (Closed)
Patch Set: restore enum Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/debug/debug-interface.h ('k') | src/runtime/runtime-function.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 the V8 project authors. All rights reserved. 1 // Copyright 2016 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/inspector/inspected-context.h" 5 #include "src/inspector/inspected-context.h"
6 6
7 #include "src/debug/debug-interface.h"
7 #include "src/inspector/injected-script.h" 8 #include "src/inspector/injected-script.h"
8 #include "src/inspector/string-util.h" 9 #include "src/inspector/string-util.h"
9 #include "src/inspector/v8-console.h" 10 #include "src/inspector/v8-console.h"
10 #include "src/inspector/v8-inspector-impl.h" 11 #include "src/inspector/v8-inspector-impl.h"
11 #include "src/inspector/v8-value-copier.h" 12 #include "src/inspector/v8-value-copier.h"
12 13
13 #include "include/v8-inspector.h" 14 #include "include/v8-inspector.h"
14 15
15 namespace v8_inspector { 16 namespace v8_inspector {
16 17
17 InspectedContext::InspectedContext(V8InspectorImpl* inspector, 18 InspectedContext::InspectedContext(V8InspectorImpl* inspector,
18 const V8ContextInfo& info, int contextId) 19 const V8ContextInfo& info, int contextId)
19 : m_inspector(inspector), 20 : m_inspector(inspector),
20 m_context(info.context->GetIsolate(), info.context), 21 m_context(info.context->GetIsolate(), info.context),
21 m_contextId(contextId), 22 m_contextId(contextId),
22 m_contextGroupId(info.contextGroupId), 23 m_contextGroupId(info.contextGroupId),
23 m_origin(toString16(info.origin)), 24 m_origin(toString16(info.origin)),
24 m_humanReadableName(toString16(info.humanReadableName)), 25 m_humanReadableName(toString16(info.humanReadableName)),
25 m_auxData(toString16(info.auxData)), 26 m_auxData(toString16(info.auxData)),
26 m_reported(false) { 27 m_reported(false) {
27 v8::Isolate* isolate = m_inspector->isolate(); 28 v8::Isolate* isolate = m_inspector->isolate();
28 info.context->SetEmbedderData(static_cast<int>(v8::Context::kDebugIdIndex), 29 v8::debug::SetContextId(info.context, contextId);
29 v8::Int32::New(isolate, contextId));
30 v8::Local<v8::Object> global = info.context->Global(); 30 v8::Local<v8::Object> global = info.context->Global();
31 v8::Local<v8::Object> console = 31 v8::Local<v8::Object> console =
32 m_inspector->console()->createConsole(info.context); 32 m_inspector->console()->createConsole(info.context);
33 if (info.hasMemoryOnConsole) { 33 if (info.hasMemoryOnConsole) {
34 m_inspector->console()->installMemoryGetter(info.context, console); 34 m_inspector->console()->installMemoryGetter(info.context, console);
35 } 35 }
36 if (!global 36 if (!global
37 ->Set(info.context, toV8StringInternalized(isolate, "console"), 37 ->Set(info.context, toV8StringInternalized(isolate, "console"),
38 console) 38 console)
39 .FromMaybe(false)) { 39 .FromMaybe(false)) {
40 return; 40 return;
41 } 41 }
42 } 42 }
43 43
44 InspectedContext::~InspectedContext() { 44 InspectedContext::~InspectedContext() {
45 } 45 }
46 46
47 // static 47 // static
48 int InspectedContext::contextId(v8::Local<v8::Context> context) { 48 int InspectedContext::contextId(v8::Local<v8::Context> context) {
49 v8::Local<v8::Value> data = 49 return v8::debug::GetContextId(context);
50 context->GetEmbedderData(static_cast<int>(v8::Context::kDebugIdIndex));
51 if (data.IsEmpty() || !data->IsInt32()) return 0;
52 return static_cast<int>(data.As<v8::Int32>()->Value());
53 } 50 }
54 51
55 v8::Local<v8::Context> InspectedContext::context() const { 52 v8::Local<v8::Context> InspectedContext::context() const {
56 return m_context.Get(isolate()); 53 return m_context.Get(isolate());
57 } 54 }
58 55
59 v8::Isolate* InspectedContext::isolate() const { 56 v8::Isolate* InspectedContext::isolate() const {
60 return m_inspector->isolate(); 57 return m_inspector->isolate();
61 } 58 }
62 59
63 bool InspectedContext::createInjectedScript() { 60 bool InspectedContext::createInjectedScript() {
64 DCHECK(!m_injectedScript); 61 DCHECK(!m_injectedScript);
65 std::unique_ptr<InjectedScript> injectedScript = InjectedScript::create(this); 62 std::unique_ptr<InjectedScript> injectedScript = InjectedScript::create(this);
66 // InjectedScript::create can destroy |this|. 63 // InjectedScript::create can destroy |this|.
67 if (!injectedScript) return false; 64 if (!injectedScript) return false;
68 m_injectedScript = std::move(injectedScript); 65 m_injectedScript = std::move(injectedScript);
69 return true; 66 return true;
70 } 67 }
71 68
72 void InspectedContext::discardInjectedScript() { m_injectedScript.reset(); } 69 void InspectedContext::discardInjectedScript() { m_injectedScript.reset(); }
73 70
74 } // namespace v8_inspector 71 } // namespace v8_inspector
OLDNEW
« no previous file with comments | « src/debug/debug-interface.h ('k') | src/runtime/runtime-function.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698