Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(743)

Issue 2806253002: Removes wifi dependency for testHistoryEntriesStatusCell. (Closed)

Created:
3 years, 8 months ago by ramyasharma
Modified:
3 years, 8 months ago
Reviewers:
sczs
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Removes wifi dependency for testHistoryEntriesStatusCell, so that it passes reliably when running on devices with WIFI turned off. The test, was checking the web contents of the URL as the last step which is unnecessary. This test is meant to test the history entries, and that the right number of tabs are opened in the end. The contents of the URL are not important. BUG=709135 Review-Url: https://codereview.chromium.org/2806253002 Cr-Commit-Position: refs/heads/master@{#463441} Committed: https://chromium.googlesource.com/chromium/src/+/ac504ddefaadc3b933db8cffde4a599539c89b79

Patch Set 1 : a #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -10 lines) Patch
M ios/chrome/browser/ui/history/history_ui_egtest.mm View 2 chunks +2 lines, -10 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
ramyasharma
3 years, 8 months ago (2017-04-10 06:55:31 UTC) #4
sczs
lgtm Now we will check if a new Tab was opened but not if the ...
3 years, 8 months ago (2017-04-10 18:45:01 UTC) #10
ramyasharma
On 2017/04/10 18:45:01, sczs wrote: > lgtm > > Now we will check if a ...
3 years, 8 months ago (2017-04-10 23:14:03 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2806253002/20001
3 years, 8 months ago (2017-04-10 23:14:56 UTC) #13
commit-bot: I haz the power
3 years, 8 months ago (2017-04-10 23:23:10 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ac504ddefaadc3b933db8cffde4a...

Powered by Google App Engine
This is Rietveld 408576698