Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Unified Diff: ios/chrome/browser/ui/history/history_ui_egtest.mm

Issue 2806253002: Removes wifi dependency for testHistoryEntriesStatusCell. (Closed)
Patch Set: a Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/ui/history/history_ui_egtest.mm
diff --git a/ios/chrome/browser/ui/history/history_ui_egtest.mm b/ios/chrome/browser/ui/history/history_ui_egtest.mm
index 98eced10c14db056efee8d024e6ebecc5e5f39e4..3f208318a1c3c256b637526bfcfa12706b46d9d8 100644
--- a/ios/chrome/browser/ui/history/history_ui_egtest.mm
+++ b/ios/chrome/browser/ui/history/history_ui_egtest.mm
@@ -285,11 +285,6 @@ void MockSignIn() {
// in, and that tapping on the link in the message opens a new tab with the sync
// help page.
- (void)testHistoryEntriesStatusCell {
-// TODO(crbug.com/709135): Evaluate and re-enable this test if necessary.
-#if !TARGET_IPHONE_SIMULATOR
- EARL_GREY_TEST_DISABLED(@"Test disabled on device.");
-#endif
-
[self loadTestURLs];
[self openHistoryPanel];
// Assert that no message is shown when the user is not signed in.
@@ -310,15 +305,12 @@ void MockSignIn() {
[[EarlGrey selectElementWithMatcher:grey_text(entriesMessage)]
assertWithMatcher:grey_notNil()];
- // Tap on "Learn more" link and assert that new tab with the link is opened.
+ // Tap on "Learn more" link.
[[EarlGrey
selectElementWithMatcher:grey_kindOfClass([TransparentLinkButton class])]
performAction:grey_tap()];
+ // Assert that new tab with the link is opened, hence tab count of 2.
chrome_test_util::AssertMainTabCount(2);
- id<GREYMatcher> webViewMatcher =
- WebViewContainingText("Sync and view tabs and history across devices");
- [[EarlGrey selectElementWithMatcher:webViewMatcher]
- assertWithMatcher:grey_notNil()];
}
// Tests that searching history displays only entries matching the search term.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698