Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 2806143002: Temporarily (for M58) disable byte counter on Download Page notifications. (Closed)

Created:
3 years, 8 months ago by Dmitry Titov
Modified:
3 years, 8 months ago
CC:
chromium-reviews, David Trainor- moved to gerrit, dewittj+watch_chromium.org, fgorski+watch_chromium.org, romax+watch_chromium.org, petewil+watch_chromium.org, chili+watch_chromium.org, agrieve+watch_chromium.org, dimich+watch_chromium.org, shaktisahu
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Temporarily (for M58) disable byte counter on Download Page notifications. It is replaced with "Downloading..." string. This prevents the indeterminate progress bar reset on every notification update. The Download Home behavior si unaffected (still has byte counter), and other state transitions (paused, pending etc) still work as expected. BUG=704049 Review-Url: https://codereview.chromium.org/2806143002 Cr-Commit-Position: refs/heads/master@{#463289} Committed: https://chromium.googlesource.com/chromium/src/+/de94e722f95b295b6150013fb8e42f1891078c3a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java View 1 chunk +3 lines, -2 lines 0 comments Download
M components/offline_pages/core/downloads/download_notifying_observer.cc View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (12 generated)
Dmitry Titov
Tested this manually, looked at notifications and Download Home, the regular downloads not affectd, Page ...
3 years, 8 months ago (2017-04-09 20:00:05 UTC) #4
David Trainor- moved to gerrit
lgtm. I think this is what shakti was doing as well. CC'ing him so he ...
3 years, 8 months ago (2017-04-10 15:51:39 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2806143002/1
3 years, 8 months ago (2017-04-10 16:25:40 UTC) #13
commit-bot: I haz the power
3 years, 8 months ago (2017-04-10 16:33:18 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/de94e722f95b295b6150013fb8e4...

Powered by Google App Engine
This is Rietveld 408576698