Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1246)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java

Issue 2806143002: Temporarily (for M58) disable byte counter on Download Page notifications. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/offline_pages/core/downloads/download_notifying_observer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java b/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java
index 14553c8d33b6726ba1762010ca37d429ae978dc1..095e521f848c3071eb0d7c7389dbdfb92bf1dea2 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java
@@ -799,8 +799,9 @@ public class DownloadNotificationService extends Service {
if (isDownloadPending) {
contentText = mContext.getResources().getString(R.string.download_notification_pending);
} else if (indeterminate) {
- contentText = DownloadUtils.getStringForBytes(
- mContext, DownloadUtils.BYTES_DOWNLOADED_STRINGS, bytesReceived);
+ // TODO(dimich): Enable the byte count back in M59. See bug 704049 for more info and
+ // details of what was temporarily reverted (for M58).
+ contentText = mContext.getResources().getString(R.string.download_started);
} else {
contentText = timeRemainingInMillis < 0
? mContext.getResources().getString(R.string.download_started)
« no previous file with comments | « no previous file | components/offline_pages/core/downloads/download_notifying_observer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698