[Payments] Move JourneyLogger unit tests from Java to C++.

[Payments] Move JourneyLogger unit tests from Java to C++.

BUG=709529
TBR=rouslan@chromium.org

Review-Url: https://codereview.chromium.org/2805913002
Cr-Commit-Position: refs/heads/master@{#462983}
Committed: https://chromium.googlesource.com/chromium/src/+/24d1d608245a0e164b9d1081a322de8df4cf2887

[sebsg, 2017-04-07 17:25:17]

sebsg@chromium.org changed reviewers:
+ mathp@chromium.org

[sebsg, 2017-04-07 17:25:18]

Hi Math, PTAL?

[sebsg, 2017-04-07 17:34:48]

The CQ bit was checked by sebsg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-07 17:35:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Mathieu, 2017-04-07 18:28:01]

lgtm

https://codereview.chromium.org/2805913002/diff/1/components/payments/core/jo...
File components/payments/core/journey_logger_unittest.cc (right):

https://codereview.chromium.org/2805913002/diff/1/components/payments/core/jo...
components/payments/core/journey_logger_unittest.cc:10: 
can you do

using testing::ContainerEq; 

here?

https://codereview.chromium.org/2805913002/diff/1/components/payments/core/jo...
components/payments/core/journey_logger_unittest.cc:22: JourneyLogger
logger(false /* is_incognito */);
nit: I like /*is_incognito=*/false

It makes sure it's always shown on the same line

[commit-bot: I haz the power, 2017-04-07 18:37:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-07 18:37:12]

Dry run: This issue passed the CQ dry run.

[sebsg, 2017-04-07 19:05:03]

Patchset #2 (id:20001) has been deleted

[sebsg, 2017-04-07 19:05:48]

Hi Rouslan, can you take a look at the deleted
PaymentRequestJourneyLoggerUnitTest.java?

Thanks!

https://codereview.chromium.org/2805913002/diff/1/components/payments/core/jo...
File components/payments/core/journey_logger_unittest.cc (right):

https://codereview.chromium.org/2805913002/diff/1/components/payments/core/jo...
components/payments/core/journey_logger_unittest.cc:10: 
On 2017/04/07 18:28:01, Mathieu wrote:
> can you do
> 
> using testing::ContainerEq; 
> 
> here?

Done.

https://codereview.chromium.org/2805913002/diff/1/components/payments/core/jo...
components/payments/core/journey_logger_unittest.cc:22: JourneyLogger
logger(false /* is_incognito */);
On 2017/04/07 18:28:01, Mathieu wrote:
> nit: I like /*is_incognito=*/false
> 
> It makes sure it's always shown on the same line

Done.

[sebsg, 2017-04-07 19:05:55]

The CQ bit was checked by sebsg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-07 19:06:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sebsg, 2017-04-07 19:09:02]

Description was changed from

==========
[Payments] Move JourneyLogger unit tests from Java to C++.

BUG=709529
==========

to

==========
[Payments] Move JourneyLogger unit tests from Java to C++.

BUG=709529

TBR=rouslan@chromium.org
==========

[sebsg, 2017-04-07 19:11:37]

The CQ bit was unchecked by sebsg@chromium.org

[sebsg, 2017-04-07 19:11:37]

The CQ bit was checked by sebsg@chromium.org

[sebsg, 2017-04-07 19:11:37]

The patchset sent to the CQ was uploaded after l-g-t-m from mathp@chromium.org
Link to the patchset: https://codereview.chromium.org/2805913002/#ps40001
(title: "Addressed Math's comments")

[commit-bot: I haz the power, 2017-04-07 19:12:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 20:20:18]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1491592297636050,
"parent_rev": "333a624229a859b3388e4c6af0f29197709991a2", "commit_rev":
"24d1d608245a0e164b9d1081a322de8df4cf2887"}

[commit-bot: I haz the power, 2017-04-07 20:21:07]

Description was changed from

==========
[Payments] Move JourneyLogger unit tests from Java to C++.

BUG=709529

TBR=rouslan@chromium.org
==========

to

==========
[Payments] Move JourneyLogger unit tests from Java to C++.

BUG=709529

TBR=rouslan@chromium.org

Review-Url: https://codereview.chromium.org/2805913002
Cr-Commit-Position: refs/heads/master@{#462983}
Committed:
https://chromium.googlesource.com/chromium/src/+/24d1d608245a0e164b9d1081a322...
==========

[commit-bot: I haz the power, 2017-04-07 20:21:08]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/24d1d608245a0e164b9d1081a322...