components/payments/core/journey_logger.cc - Issue 2805913002: [Payments] Move JourneyLogger unit tests from Java to C++.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/payments/core/journey_logger.cc

Issue 2805913002: [Payments] Move JourneyLogger unit tests from Java to C++. (Closed)

Patch Set: Addressed Math's comments Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/payments/core/journey_logger.cc

diff --git a/components/payments/core/journey_logger.cc b/components/payments/core/journey_logger.cc

index a62e2e23fcb22b4e8b01eb175516670b203857d8..d8731c053ff7c1f2bb6bc300ac731deef71cf744 100644

--- a/components/payments/core/journey_logger.cc

+++ b/components/payments/core/journey_logger.cc

@@ -175,7 +175,7 @@ void JourneyLogger::RecordCanMakePaymentEffectOnShow() {

if (was_show_called_)

effect_on_show |= CMP_SHOW_DID_SHOW;

if (could_make_payment_)

- effect_on_show |= CMP_SHOW_COULD_MAKE_PAYMENT_;

+ effect_on_show |= CMP_SHOW_COULD_MAKE_PAYMENT;

UMA_HISTOGRAM_ENUMERATION("PaymentRequest.CanMakePayment.Used.EffectOnShow",

effect_on_show, CMP_SHOW_MAX);