chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationConstants.java - Issue 2805843002: Workaround for NotificationManager race condition

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationConstants.java

Issue 2805843002: Workaround for NotificationManager race condition (Closed)

Patch Set: Addressed comments Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationConstants.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationConstants.java b/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationConstants.java

index 5721df251371ba4e3c4ea789c2dcf89cc2b3c66f..eca0b774975aa786152583fd6c383a81be342310 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationConstants.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationConstants.java

@@ -29,7 +29,7 @@ public class NotificationConstants {

* When adding a new extra, as well as setting it on the intent in NotificationPlatformBridge,

* it *must* also be set in {@link NotificationJobService#getJobExtrasFromIntent(Intent)}

- static final String EXTRA_NOTIFICATION_ID = "notification_id";

+ public static final String EXTRA_NOTIFICATION_ID = "notification_id";

static final String EXTRA_NOTIFICATION_INFO_ORIGIN = "notification_info_origin";

static final String EXTRA_NOTIFICATION_INFO_PROFILE_ID = "notification_info_profile_id";

static final String EXTRA_NOTIFICATION_INFO_PROFILE_INCOGNITO =

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java ('k') | no next file » | no next file with comments »