bindings: Preprocess IDL types in native_value_traits_type_name().

bindings: Preprocess IDL types in native_value_traits_type_name().

When determining which type to use in native_value_traits_type_name(), make
sure preprocess_idl_type() is called first, otherwise types such as enums or
`any' are not converted to their final C++ types, leading to build failures.

BUG=690428
R=bashi@chromium.org,haraken@chromium.org,yukishiino@chromium.org

Review-Url: https://codereview.chromium.org/2805813004
Cr-Commit-Position: refs/heads/master@{#463218}
Committed: https://chromium.googlesource.com/chromium/src/+/d4c8b05b9769e86790dc740fa920631227a31003

[Raphael Kubo da Costa (rakuco), 2017-04-07 14:06:34]

PTAL at yet another patch :-)

bashi-san: I think you referred to this problem in
https://codereview.chromium.org/2791133002/. This patch solves it for me
(including when I convert sequences to NVT::nativeValue()), let me know if
there's anything else that needs to be done.

[Raphael Kubo da Costa (rakuco), 2017-04-07 14:07:33]

The CQ bit was checked by raphael.kubo.da.costa@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-07 14:07:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 14:08:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-07 14:08:39]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[Yuki, 2017-04-07 14:18:19]

Defer to bashi@.  If bashi@ is fine with the change, I'm fine, too.

[haraken, 2017-04-07 14:21:05]

LGTM

[Raphael Kubo da Costa (rakuco), 2017-04-07 15:53:25]

The CQ bit was checked by raphael.kubo.da.costa@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-07 15:53:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 17:15:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-07 17:15:47]

Dry run: This issue passed the CQ dry run.

[bashi, 2017-04-09 22:19:44]

On 2017/04/07 14:21:05, haraken wrote:
> LGTM

lgtm

[Raphael Kubo da Costa (rakuco), 2017-04-10 08:52:37]

The CQ bit was checked by raphael.kubo.da.costa@intel.com

[commit-bot: I haz the power, 2017-04-10 08:52:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 08:54:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-10 08:54:50]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[Raphael Kubo da Costa (rakuco), 2017-04-10 09:07:08]

The CQ bit was checked by raphael.kubo.da.costa@intel.com

[Raphael Kubo da Costa (rakuco), 2017-04-10 09:07:09]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, bashi@chromium.org
Link to the patchset: https://codereview.chromium.org/2805813004/#ps20001
(title: "Rebase after The Blink Rename")

[commit-bot: I haz the power, 2017-04-10 09:07:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 11:20:07]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491815228635210,
"parent_rev": "f7783aa80e8a3bf24c824efd925d9d7b1505b21d", "commit_rev":
"d4c8b05b9769e86790dc740fa920631227a31003"}

[commit-bot: I haz the power, 2017-04-10 11:20:52]

Description was changed from

==========
bindings: Preprocess IDL types in native_value_traits_type_name().

When determining which type to use in native_value_traits_type_name(), make
sure preprocess_idl_type() is called first, otherwise types such as enums or
`any' are not converted to their final C++ types, leading to build failures.

BUG=690428
R=bashi@chromium.org,haraken@chromium.org,yukishiino@chromium.org
==========

to

==========
bindings: Preprocess IDL types in native_value_traits_type_name().

When determining which type to use in native_value_traits_type_name(), make
sure preprocess_idl_type() is called first, otherwise types such as enums or
`any' are not converted to their final C++ types, leading to build failures.

BUG=690428
R=bashi@chromium.org,haraken@chromium.org,yukishiino@chromium.org

Review-Url: https://codereview.chromium.org/2805813004
Cr-Commit-Position: refs/heads/master@{#463218}
Committed:
https://chromium.googlesource.com/chromium/src/+/d4c8b05b9769e86790dc740fa920...
==========

[commit-bot: I haz the power, 2017-04-10 11:20:54]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d4c8b05b9769e86790dc740fa920...