bindings: Explicitly pass ValueType to toImplArray

bindings: Explicitly pass ValueType to toImplArray

This makes toImplArray use correct NativeValueTraits<T>.

BUG=707632
Review-Url: https://codereview.chromium.org/2791133002
Cr-Commit-Position: refs/heads/master@{#462346}
Committed: https://chromium.googlesource.com/chromium/src/+/0f01bbd2bd685d4987f04347e6403c3e2d13e0c9

[bashi, 2017-04-03 01:22:19]

The CQ bit was checked by bashi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-03 01:22:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-03 02:33:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-03 02:33:21]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[bashi, 2017-04-03 03:04:52]

The CQ bit was checked by bashi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-03 03:05:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-03 04:21:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-03 04:21:26]

Dry run: This issue passed the CQ dry run.

[bashi, 2017-04-03 04:24:39]

bashi@chromium.org changed reviewers:
+ rtoy@chromium.org

[bashi, 2017-04-03 04:24:39]

rtoy@: does the change in iirfilter-basic.html make sense to you?

[haraken, 2017-04-03 04:29:02]

haraken@chromium.org changed reviewers:
+ haraken@chromium.org

[haraken, 2017-04-03 04:29:03]

LGTM

https://codereview.chromium.org/2791133002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/bindings/scripts/v8_types.py (right):

https://codereview.chromium.org/2791133002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/scripts/v8_types.py:642: if
native_array_element_type.is_primitive_type:

Why do we need to limit this to primitive types?

[bashi, 2017-04-03 04:42:34]

https://codereview.chromium.org/2791133002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/bindings/scripts/v8_types.py (right):

https://codereview.chromium.org/2791133002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/scripts/v8_types.py:642: if
native_array_element_type.is_primitive_type:
On 2017/04/03 04:29:02, haraken wrote:
> 
> Why do we need to limit this to primitive types?

Just to minimize the impact of changes to see if tests are passed. I'm planning
to remove this check :)

[bashi, 2017-04-03 04:52:17]

Description was changed from

==========
bindings: Explicitly pass ValueType to toImplArray

This makes toImplArray use correct NativeValueTraits<T>.

BUG=
==========

to

==========
bindings: Explicitly pass ValueType to toImplArray

This makes toImplArray use correct NativeValueTraits<T>.

BUG=707632
==========

[bashi, 2017-04-03 05:06:25]

https://codereview.chromium.org/2791133002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/bindings/scripts/v8_types.py (right):

https://codereview.chromium.org/2791133002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/scripts/v8_types.py:642: if
native_array_element_type.is_primitive_type:
On 2017/04/03 04:42:34, bashi wrote:
> On 2017/04/03 04:29:02, haraken wrote:
> > 
> > Why do we need to limit this to primitive types?
> 
> Just to minimize the impact of changes to see if tests are passed. I'm
planning
> to remove this check :)

Looks like we need to improve coverage of native_value_traits_type_name() and
IDLTypes.h to remove this check (e.g. we need to support enums and any). Let me
address it in follow-up CLs.

[Raymond Toy, 2017-04-04 16:40:55]

lgtm for the webaudio changes

Thanks for looking into this!

[bashi, 2017-04-06 01:09:17]

The CQ bit was checked by bashi@chromium.org

[commit-bot: I haz the power, 2017-04-06 01:09:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 02:31:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-06 02:31:20]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[bashi, 2017-04-06 02:35:07]

The CQ bit was checked by bashi@chromium.org

[commit-bot: I haz the power, 2017-04-06 02:35:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 03:43:59]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491446107257940,
"parent_rev": "758647775c72508a620bd1ba203828d46bd46cb0", "commit_rev":
"0f01bbd2bd685d4987f04347e6403c3e2d13e0c9"}

[commit-bot: I haz the power, 2017-04-06 03:45:00]

Description was changed from

==========
bindings: Explicitly pass ValueType to toImplArray

This makes toImplArray use correct NativeValueTraits<T>.

BUG=707632
==========

to

==========
bindings: Explicitly pass ValueType to toImplArray

This makes toImplArray use correct NativeValueTraits<T>.

BUG=707632

Review-Url: https://codereview.chromium.org/2791133002
Cr-Commit-Position: refs/heads/master@{#462346}
Committed:
https://chromium.googlesource.com/chromium/src/+/0f01bbd2bd685d4987f04347e640...
==========

[commit-bot: I haz the power, 2017-04-06 03:45:01]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0f01bbd2bd685d4987f04347e640...

[Raphael Kubo da Costa (rakuco), 2017-04-06 13:22:36]

raphael.kubo.da.costa@intel.com changed reviewers:
+ raphael.kubo.da.costa@intel.com

[Raphael Kubo da Costa (rakuco), 2017-04-06 13:22:36]

https://codereview.chromium.org/2791133002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/bindings/scripts/v8_types.py (right):

https://codereview.chromium.org/2791133002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/scripts/v8_types.py:642: if
native_array_element_type.is_primitive_type:
On 2017/04/03 05:06:25, bashi wrote:
> Looks like we need to improve coverage of native_value_traits_type_name() and
> IDLTypes.h to remove this check (e.g. we need to support enums and any). Let
me
> address it in follow-up CLs.

(belatedly adding myself to the party)

Are you actively working on this at the moment? I'm also doing some changes to
this part of the code and stumbled upon the problems with enums & friends, but
if you already have a patch we can avoid crossing our streams.