Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 2805683005: Merge SecurityOrigin::canAccessCheckSuborigins into canAccess (Closed)

Created:
3 years, 8 months ago by jochen (gone - plz use gerrit)
Modified:
3 years, 8 months ago
Reviewers:
Mike West, dglazkov
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-bindings_chromium.org, blink-reviews-css, blink-reviews-frames_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, falken+watch_chromium.org, haraken, horo+watch_chromium.org, jsbell+serviceworker_chromium.org, kinuko+watch, kinuko+serviceworker, michaeln, nhiroki, rwlbuis, serviceworker-reviews, shimazu+serviceworker_chromium.org, tzik
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Merge SecurityOrigin::canAccessCheckSuborigins into canAccess Suborigins are supposed to make script from different suborigin namespaces inaccessible to each other. canAccess (in spec terms same-origin domain) is supposed to do that, so just fold the two together BUG=336894 R=mkwst@chromium.org Review-Url: https://codereview.chromium.org/2805683005 Cr-Commit-Position: refs/heads/master@{#462872} Committed: https://chromium.googlesource.com/chromium/src/+/33d6af4002ee5d40343ecff63d4ce017461cfa44

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -50 lines) Patch
M third_party/WebKit/Source/SpecMapping.md View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/BindingSecurity.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSStyleSheet.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/frame/DOMWindow.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/NavigatorServiceWorker.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/weborigin/SecurityOrigin.h View 2 chunks +6 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/platform/weborigin/SecurityOrigin.cpp View 2 chunks +6 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/platform/weborigin/SecurityOriginTest.cpp View 2 chunks +5 lines, -8 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
jochen (gone - plz use gerrit)
3 years, 8 months ago (2017-04-07 12:00:28 UTC) #1
dglazkov
lgtm
3 years, 8 months ago (2017-04-07 15:23:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2805683005/1
3 years, 8 months ago (2017-04-07 15:44:54 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 15:52:18 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/33d6af4002ee5d40343ecff63d4c...

Powered by Google App Engine
This is Rietveld 408576698