Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Unified Diff: third_party/WebKit/Source/platform/weborigin/SecurityOriginTest.cpp

Issue 2805683005: Merge SecurityOrigin::canAccessCheckSuborigins into canAccess (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/platform/weborigin/SecurityOrigin.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/platform/weborigin/SecurityOriginTest.cpp
diff --git a/third_party/WebKit/Source/platform/weborigin/SecurityOriginTest.cpp b/third_party/WebKit/Source/platform/weborigin/SecurityOriginTest.cpp
index 11521afd0ace41945a8259514d96e4a75af5cc9f..c8eb9450c9530bef3dcef938f19b76989e024c8c 100644
--- a/third_party/WebKit/Source/platform/weborigin/SecurityOriginTest.cpp
+++ b/third_party/WebKit/Source/platform/weborigin/SecurityOriginTest.cpp
@@ -334,17 +334,16 @@ TEST_F(SecurityOriginTest, CanAccess) {
struct TestCase {
bool canAccess;
- bool canAccessCheckSuborigins;
const char* origin1;
const char* origin2;
};
TestCase tests[] = {
- {true, true, "https://foobar.com", "https://foobar.com"},
- {false, false, "https://foobar.com", "https://bazbar.com"},
- {true, false, "https://foobar.com", "https-so://name.foobar.com"},
- {true, false, "https-so://name.foobar.com", "https://foobar.com"},
- {true, true, "https-so://name.foobar.com", "https-so://name.foobar.com"},
+ {true, "https://foobar.com", "https://foobar.com"},
+ {false, "https://foobar.com", "https://bazbar.com"},
+ {false, "https://foobar.com", "https-so://name.foobar.com"},
+ {false, "https-so://name.foobar.com", "https://foobar.com"},
+ {true, "https-so://name.foobar.com", "https-so://name.foobar.com"},
};
for (size_t i = 0; i < WTF_ARRAY_LENGTH(tests); ++i) {
@@ -353,8 +352,6 @@ TEST_F(SecurityOriginTest, CanAccess) {
RefPtr<SecurityOrigin> origin2 =
SecurityOrigin::createFromString(tests[i].origin2);
EXPECT_EQ(tests[i].canAccess, origin1->canAccess(origin2.get()));
- EXPECT_EQ(tests[i].canAccessCheckSuborigins,
- origin1->canAccessCheckSuborigins(origin2.get()));
}
}
« no previous file with comments | « third_party/WebKit/Source/platform/weborigin/SecurityOrigin.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698