Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2805633002: Count 'icon' attribute of MENUITEM element. (Closed)

Created:
3 years, 8 months ago by tkent
Modified:
3 years, 8 months ago
Reviewers:
haraken, hayato
CC:
asvitkine+watch_chromium.org, blink-reviews, blink-reviews-frames_chromium.org, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Count 'icon' attribute of MENUITEM element. Because MENUITEM element isn't enabled in production, this CL adds counting code in HTMLUnknownElement too. BUG=681444 Review-Url: https://codereview.chromium.org/2805633002 Cr-Commit-Position: refs/heads/master@{#462425} Committed: https://chromium.googlesource.com/chromium/src/+/7aee942e5dd7a866708984cf5aab977a5e35af72

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLMenuItemElement.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLMenuItemElement.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLUnknownElement.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLUnknownElement.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
tkent
hayato@, would you review this please? haraken@, would you approve histograms.xml please?
3 years, 8 months ago (2017-04-06 07:07:28 UTC) #4
hayato
lgtm
3 years, 8 months ago (2017-04-06 07:12:56 UTC) #5
haraken
LGTM
3 years, 8 months ago (2017-04-06 07:21:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2805633002/1
3 years, 8 months ago (2017-04-06 10:26:22 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 11:30:10 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7aee942e5dd7a866708984cf5aab...

Powered by Google App Engine
This is Rietveld 408576698